From: Alexander Beregalov <a.beregalov@gmail•com>
To: Matthew Wilcox <matthew@wil•cx>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
andrew.patterson@hp•com, jbarnes@virtuousgeek•org,
linux-pci@vger•kernel.org
Subject: Re: [PATCH next] pci: fix build error with !PCIE_ECRC
Date: Tue, 7 Apr 2009 18:41:28 +0400 [thread overview]
Message-ID: <a4423d670904070741h23ce6d10pf775b67c25f9899d@mail.gmail.com> (raw)
In-Reply-To: <20090407143248.GA21727@parisc-linux.org>
2009/4/7 Matthew Wilcox <matthew@wil•cx>:
> On Tue, Apr 07, 2009 at 04:37:08PM +0400, Alexander Beregalov wrote:
>> Fix this build error:
>> drivers/built-in.o: In function `pci_init_capabilities':
>> drivers/pci/probe.c:989: undefined reference to `pcie_set_ecrc_checking'
>> drivers/built-in.o: In function `pci_setup':
>> drivers/pci/pci.c:2547: undefined reference to `pcie_ecrc_get_policy'
>
>> config PCIE_ECRC
>> bool "PCI Express ECRC support"
>> - depends on PCI
>> + depends on PCI && PCIEPORTBUS
>
> How does this part of the patch relate to the above description?
Right, I agree. This should be another patch "PCIE_ECRC should depend on PCIE"
When I found this problem PCIE_ECRC was set, but was not be built in.
My problem needs both patches to be fixed, I will send them few hours later.
next prev parent reply other threads:[~2009-04-07 14:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 12:37 [PATCH next] pci: fix build error with !PCIE_ECRC Alexander Beregalov
2009-04-07 14:32 ` Matthew Wilcox
2009-04-07 14:41 ` Alexander Beregalov [this message]
2009-04-07 17:33 ` Andrew Patterson
2009-04-07 21:52 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4423d670904070741h23ce6d10pf775b67c25f9899d@mail.gmail.com \
--to=a.beregalov@gmail$(echo .)com \
--cc=andrew.patterson@hp$(echo .)com \
--cc=jbarnes@virtuousgeek$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=matthew@wil$(echo .)cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox