From: Alexander Beregalov <a.beregalov@gmail•com>
To: Feng Tang <feng.tang@intel•com>
Cc: Len Brown <lenb@kernel•org>,
linux-next <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
"linux-acpi@vger•kernel.org" <linux-acpi@vger•kernel.org>
Subject: Re: next: sfi build fails when !CONFIG_ACPI
Date: Thu, 23 Jul 2009 15:28:29 +0400 [thread overview]
Message-ID: <a4423d670907230428g48cd2b70wf3d26d2c1378503f@mail.gmail.com> (raw)
In-Reply-To: <20090723181525.475692d3@feng-desktop>
2009/7/23 Feng Tang <feng.tang@intel•com>:
> On Thu, 23 Jul 2009 16:43:30 +0800
> Alexander Beregalov <a.beregalov@gmail•com> wrote:
>
>> 2009/7/17 Alexander Beregalov <a.beregalov@gmail•com>:
>> > 2009/7/17 Len Brown <lenb@kernel•org>:
>> >>> drivers/sfi/sfi_core.c: In function 'sfi_init':
>> >>> drivers/sfi/sfi_core.c:346: error: 'acpi_disabled' undeclared
>> >>> (first use in this function)
>> >>> drivers/sfi/sfi_core.c:346: error: (Each undeclared identifier is
>> >>> reported only once
>> >>> drivers/sfi/sfi_core.c:346: error: for each function it appears
>> >>> in.)
>> >>>
>> >>>
>> >>> $ grep ACPI .config
>> >>> # Power management and ACPI options
>> >>
>> >> It builds for me.
>> >> Please send me the complete failing .config
>> >
>> > Attached (x86_64)
>>
>> Still fails for me in the same way,
>> X86_64
>> next-20090723
>
> sorry for the late response, please try the following patch:
It obviously works. Thanks
>
> diff --git a/drivers/sfi/sfi_core.c b/drivers/sfi/sfi_core.c
> index 62e2f98..fa66824 100644
> --- a/drivers/sfi/sfi_core.c
> +++ b/drivers/sfi/sfi_core.c
> @@ -361,9 +361,6 @@ static __init int sfi_find_syst(void)
>
> void __init sfi_init(void)
> {
> - if (!acpi_disabled)
> - disable_sfi();
> -
> if (sfi_disabled)
> return;
>
> Thanks,
> Feng
>
next prev parent reply other threads:[~2009-07-23 11:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 8:48 next: sfi build fails when !CONFIG_ACPI Alexander Beregalov
2009-07-17 1:46 ` Len Brown
2009-07-17 13:57 ` Alexander Beregalov
2009-07-23 8:43 ` Alexander Beregalov
2009-07-23 10:15 ` Feng Tang
2009-07-23 11:28 ` Alexander Beregalov [this message]
2009-07-22 22:06 ` Randy Dunlap
2009-07-23 8:33 ` Feng Tang
2009-07-23 14:53 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4423d670907230428g48cd2b70wf3d26d2c1378503f@mail.gmail.com \
--to=a.beregalov@gmail$(echo .)com \
--cc=feng.tang@intel$(echo .)com \
--cc=lenb@kernel$(echo .)org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox