public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead•org>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
	Linux Next Mailing List <linux-next@vger•kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
	Khalil Blaiech <kblaiech@nvidia•com>,
	Asmaa Mnebhi <asmaa@nvidia•com>,
	linux-i2c@vger•kernel.org
Subject: Re: linux-next: Tree for May 9 (i2c/busses/i2c-mlxbf.c)
Date: Fri, 9 May 2025 17:18:40 -0700	[thread overview]
Message-ID: <a4e821f9-9daa-4a65-b41a-200a6da85191@infradead.org> (raw)
In-Reply-To: <20250509195816.7f0a67a3@canb.auug.org.au>



On 5/9/25 2:58 AM, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20250508:
> 

on i386:

ld: drivers/i2c/busses/i2c-mlxbf.o: in function `mlxbf_i2c_set_timings':
i2c-mlxbf.c:(.text+0x67): undefined reference to `__udivdi3'
ld: i2c-mlxbf.c:(.text+0x8a): undefined reference to `__udivdi3'
ld: i2c-mlxbf.c:(.text+0xc7): undefined reference to `__udivdi3'
ld: i2c-mlxbf.c:(.text+0xeb): undefined reference to `__udivdi3'
ld: i2c-mlxbf.c:(.text+0x112): undefined reference to `__udivdi3'

ld: drivers/i2c/busses/i2c-mlxbf.o: in function `mlxbf_i2c_calculate_freq_from_tyu':
i2c-mlxbf.c:(.text+0x194): undefined reference to `__udivdi3'
ld: drivers/i2c/busses/i2c-mlxbf.o: in function `mlxbf_i2c_calculate_freq_from_yu':
i2c-mlxbf.c:(.text+0x1e0): undefined reference to `__udivdi3'

These come fromm using '/' instead of one of the kernel's DIV macros when using
u64 or ULL  data types.

in mlxbf_i2c_get_ticks():

	ticks = (nanoseconds * frequency) / MLXBF_I2C_FREQUENCY_1GHZ;

in mlxbf_i2c_calculate_freq_from_yu():

	corepll_frequency = (MLXBF_I2C_PLL_IN_FREQ * core_f) / MLNXBF_I2C_COREPLL_CONST;
	corepll_frequency /= (++core_r) * (++core_od);

in mlxbf_i2c_calculate_freq_from_tyu():

	core_frequency /= (++core_r) * (++core_od);


commit 37f071ec327b0 ("i2c: mlxbf: Fix frequency calculation")


-- 
~Randy


  reply	other threads:[~2025-05-10  0:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-09  9:58 linux-next: Tree for May 9 Stephen Rothwell
2025-05-10  0:18 ` Randy Dunlap [this message]
2025-05-10  1:35 ` linux-next: Tree for May 9 (drivers/platform/x86/tuxedo/nb04/wmi_ab.o) Randy Dunlap
2025-05-11 23:00   ` Armin Wolf
2025-05-12  9:47     ` Werner Sembach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4e821f9-9daa-4a65-b41a-200a6da85191@infradead.org \
    --to=rdunlap@infradead$(echo .)org \
    --cc=asmaa@nvidia$(echo .)com \
    --cc=kblaiech@nvidia$(echo .)com \
    --cc=linux-i2c@vger$(echo .)kernel.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox