From: Raag Jadav <raag.jadav@intel•com>
To: "André Almeida" <andrealmeid@igalia•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
airlied@gmail•com, simona@ffwll•ch,
Krzysztof Karas <krzysztof.karas@intel•com>,
dri-devel@lists•freedesktop.org, linux-kernel@vger•kernel.org,
kernel-dev@igalia•com
Subject: Re: [PATCH v2 2/2] drm: Add missing struct drm_wedge_task_info kernel doc
Date: Fri, 27 Jun 2025 19:04:40 +0300 [thread overview]
Message-ID: <aF7BGBE1Gf7vBHDC@black.fi.intel.com> (raw)
In-Reply-To: <aF6WpMe9Ar8jmXOX@black.fi.intel.com>
On Fri, Jun 27, 2025 at 04:03:32PM +0300, Raag Jadav wrote:
> On Thu, Jun 19, 2025 at 11:06:55AM -0300, André Almeida wrote:
> > Fix the following kernel doc warning:
> >
> > include/drm/drm_device.h:40: warning: Function parameter or struct member 'pid' not described in 'drm_wedge_task_info'
> > include/drm/drm_device.h:40: warning: Function parameter or struct member 'comm' not described in 'drm_wedge_task_info'
> >
> > Fixes: 183bccafa176 ("drm: Create a task info option for wedge events")
> > Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
> > Signed-off-by: André Almeida <andrealmeid@igalia•com>
> > ---
> > v2: Add Reported-by tag
> > ---
> > include/drm/drm_device.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/include/drm/drm_device.h b/include/drm/drm_device.h
> > index 08b3b2467c4c..aae0800ccef1 100644
> > --- a/include/drm/drm_device.h
> > +++ b/include/drm/drm_device.h
> > @@ -33,6 +33,8 @@ struct pci_controller;
> >
> > /**
> > * struct drm_wedge_task_info - information about the guilty task of a wedge dev
> > + * @pid: the pid of the task
> > + * @comm: the command name of the task
>
> Redundant tabs. A whitespace is ususally good enough for docs.
Also, let's be consistent with struct drm_device for member description.
Raag
> > */
> > struct drm_wedge_task_info {
> > pid_t pid;
> > --
> > 2.49.0
> >
next prev parent reply other threads:[~2025-06-27 16:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250619140655.2468014-1-andrealmeid@igalia.com>
2025-06-24 15:25 ` [PATCH v2 1/2] drm/doc: Fix title underline for "Task information" André Almeida
[not found] ` <20250619140655.2468014-2-andrealmeid@igalia.com>
2025-06-27 13:03 ` [PATCH v2 2/2] drm: Add missing struct drm_wedge_task_info kernel doc Raag Jadav
2025-06-27 16:04 ` Raag Jadav [this message]
2025-06-27 13:11 ` [PATCH v2 1/2] drm/doc: Fix title underline for "Task information" Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF7BGBE1Gf7vBHDC@black.fi.intel.com \
--to=raag.jadav@intel$(echo .)com \
--cc=airlied@gmail$(echo .)com \
--cc=andrealmeid@igalia$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=kernel-dev@igalia$(echo .)com \
--cc=krzysztof.karas@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=simona@ffwll$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox