From: Carlos Llamas <cmllamas@google•com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
Cc: "Thorsten Leemhuis" <linux@leemhuis•info>,
"Li Li" <dualli@google•com>, "Tiffany Yang" <ynaffit@google•com>,
"John Stultz" <jstultz@google•com>,
"Shai Barack" <shayba@google•com>,
"Thiébaud Weksteen" <tweek@google•com>,
kernel-team@android•com, linux-kernel@vger•kernel.org,
"David S. Miller" <davem@davemloft•net>,
"Joel Fernandes" <joelagnelf@nvidia•com>,
"Todd Kjos" <tkjos@android•com>,
"Arve Hjønnevåg" <arve@android•com>,
"Donald Hunter" <donald.hunter@gmail•com>,
"Christian Brauner" <brauner@kernel•org>,
"Eric Dumazet" <edumazet@google•com>,
"open list:NETWORKING [GENERAL]" <netdev@vger•kernel.org>,
"Martijn Coenen" <maco@android•com>,
"Stephen Rothwell" <sfr@canb•auug.org.au>,
"Linux Next Mailing List" <linux-next@vger•kernel.org>,
"Jakub Kicinski" <kuba@kernel•org>,
"Linux kernel regressions list" <regressions@lists•linux.dev>,
"Alice Ryhl" <aliceryhl@google•com>,
"Suren Baghdasaryan" <surenb@google•com>,
"Paolo Abeni" <pabeni@redhat•com>,
"Simon Horman" <horms@kernel•org>
Subject: Re: [PATCH v20 3/5] binder: introduce transaction reports via netlink
Date: Thu, 21 Aug 2025 13:38:54 +0000 [thread overview]
Message-ID: <aKchboXyR1oQDV_e@google.com> (raw)
In-Reply-To: <2025082120-phoney-husband-d028@gregkh>
On Thu, Aug 21, 2025 at 03:25:59PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Aug 21, 2025 at 03:00:50PM +0200, Thorsten Leemhuis wrote:
> > On 21.08.25 14:19, Greg Kroah-Hartman wrote:
> > > On Thu, Aug 21, 2025 at 10:49:09AM +0200, Thorsten Leemhuis wrote:
> > >> On 27.07.25 20:29, Carlos Llamas wrote:
> > >>> From: Li Li <dualli@google•com>
> > >>>
> > >>> Introduce a generic netlink multicast event to report binder transaction
> > >>> failures to userspace. This allows subscribers to monitor these events
> > >>> and take appropriate actions, such as stopping a misbehaving application
> > >>> that is spamming a service with huge amount of transactions.
> > >>>
> > >>> The multicast event contains full details of the failed transactions,
> > >>> including the sender/target PIDs, payload size and specific error code.
> > >>> This interface is defined using a YAML spec, from which the UAPI and
> > >>> kernel headers and source are auto-generated.
> > >>
> > >> It seems to me like this patch (which showed up in -next today after
> > >> Greg merged it) caused a build error for me in my daily -next builds
> > >> for Fedora when building tools/net/ynl:
> > >>
> > >> """
> > >> make[1]: Entering directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/lib'
> > >> gcc -std=gnu11 -O2 -W -Wall -Wextra -Wno-unused-parameter -Wshadow -c -MMD -c -o ynl.o ynl.c
> > >> AR ynl.a
> > >> make[1]: Leaving directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/lib'
> > >> make[1]: Entering directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated'
> > >> GEN binder-user.c
> > >> Traceback (most recent call last):
> > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated/../pyynl/ynl_gen_c.py", line 3673, in <module>
> > >> main()
> > >> ~~~~^^
> > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated/../pyynl/ynl_gen_c.py", line 3382, in main
> > >> parsed = Family(args.spec, exclude_ops)
> > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated/../pyynl/ynl_gen_c.py", line 1205, in __init__
> > >> super().__init__(file_name, exclude_ops=exclude_ops)
> > >> ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/pyynl/lib/nlspec.py", line 462, in __init__
> > >> jsonschema.validate(self.yaml, schema)
> > >> ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
> > >> File "/usr/lib/python3.13/site-packages/jsonschema/validators.py", line 1307, in validate
> > >> raise error
> > >> jsonschema.exceptions.ValidationError: 'from_pid' does not match '^[0-9a-z-]+$'
> > >>
> > >> Failed validating 'pattern' in schema['properties']['attribute-sets']['items']['properties']['attributes']['items']['properties']['name']:
> > >> {'pattern': '^[0-9a-z-]+$', 'type': 'string'}
> > >>
> > >> On instance['attribute-sets'][0]['attributes'][2]['name']:
> > >> 'from_pid'
> > >> make[1]: *** [Makefile:48: binder-user.c] Error 1
> > >> make[1]: Leaving directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated'
> > >> make: *** [Makefile:25: generated] Error 2
> > >> """
> > >
> > > Odd, this works for me.
> >
> > Hmmm, happened on various Fedora releases and archs in Fedora's coprs
> > buildsys for me today. And with a local Fedora 41 x86_64 install, too;
> > in the latter case (just verified) both when checking out next-20250821
> > and 63740349eba78f ("binder: introduce transaction reports via netlink")
> > from -next.
> >
> > > How exactly are you building this?
> >
> > Just "cd tools/net/ynl; make".
>
> Odd, this works for me in the driver-core-next branch, but in linux-next
> it blows up like this. Is it a merge issue somewhere? I don't know
> what this tool is doing to attempt to debug it myself, sorry.
>
> greg k-h
The commit enforcing the restriction on underscores is:
af852f1f1c95 ("netlink: specs: enforce strict naming of properties")
I'm able to reproduce the issue locally now, and switching to dashes
fixes it. Sorry, I was not aware of this restriction but I'll send a
quick patch to fix this.
--
Carlos Llamas
next prev parent reply other threads:[~2025-08-21 13:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250727182932.2499194-1-cmllamas@google.com>
[not found] ` <20250727182932.2499194-4-cmllamas@google.com>
2025-08-21 8:49 ` [PATCH v20 3/5] binder: introduce transaction reports via netlink Thorsten Leemhuis
2025-08-21 12:19 ` Greg Kroah-Hartman
2025-08-21 13:00 ` Thorsten Leemhuis
2025-08-21 13:25 ` Greg Kroah-Hartman
2025-08-21 13:38 ` Carlos Llamas [this message]
2025-08-21 13:29 ` Carlos Llamas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKchboXyR1oQDV_e@google.com \
--to=cmllamas@google$(echo .)com \
--cc=aliceryhl@google$(echo .)com \
--cc=arve@android$(echo .)com \
--cc=brauner@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=dualli@google$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=horms@kernel$(echo .)org \
--cc=joelagnelf@nvidia$(echo .)com \
--cc=jstultz@google$(echo .)com \
--cc=kernel-team@android$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux@leemhuis$(echo .)info \
--cc=maco@android$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=regressions@lists$(echo .)linux.dev \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=shayba@google$(echo .)com \
--cc=surenb@google$(echo .)com \
--cc=tkjos@android$(echo .)com \
--cc=tweek@google$(echo .)com \
--cc=ynaffit@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox