From: Mark Brown <broonie@kernel•org>
To: Al Viro <viro@zeniv•linux.org.uk>,
Christian Brauner <brauner@kernel•org>
Cc: Amir Goldstein <amir73il@gmail•com>,
buildfailureaftermergeofthevfstree@sirena•org.uk,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: linux-next: build failure in the vfs tree
Date: Mon, 15 Sep 2025 21:14:03 +0100 [thread overview]
Message-ID: <aMhzi0WpakpN7oH5@sirena.org.uk> (raw)
[-- Attachment #1: Type: text/plain, Size: 1554 bytes --]
Hi all,
After merging the vfs tree, today's linux-next build (arm64 defconfig)
failed like this:
/tmp/next/build/fs/nsfs.c:582:27: error: initialization of 'struct file * (*)(const struct path *, unsigned int)' from incompatible pointer type 'struct file * (*)(struct path *, unsigned int)' [-Wincompatible-pointer-types]
582 | .open = nsfs_export_open,
| ^~~~~~~~~~~~~~~~
/tmp/next/build/fs/nsfs.c:582:27: note: (near initialization for 'nsfs_export_operations.open')
Caused by an interaction with commit
06c4ff965e95b ("nsfs: support file handles")
from the vfs-brauner tree and
efa6ab3688a54 ("export_operations->open(): constify path argument")
I've fixed it up as below and can carry as required.
From 56e625f1566ee6e3940c625a393b3b4e75806b3f Mon Sep 17 00:00:00 2001
From: Mark Brown <broonie@kernel•org>
Date: Mon, 15 Sep 2025 21:03:13 +0100
Subject: [PATCH] nsfs: Fix up merge
Signed-off-by: Mark Brown <broonie@kernel•org>
---
fs/nsfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nsfs.c b/fs/nsfs.c
index 8484bc4dd3deb..32cb8c835a2ba 100644
--- a/fs/nsfs.c
+++ b/fs/nsfs.c
@@ -571,7 +571,7 @@ static int nsfs_export_permission(struct handle_to_path_ctx *ctx,
return 0;
}
-static struct file *nsfs_export_open(struct path *path, unsigned int oflags)
+static struct file *nsfs_export_open(const struct path *path, unsigned int oflags)
{
return file_open_root(path, "", oflags, 0);
}
--
2.47.2
.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2025-09-15 20:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 20:14 Mark Brown [this message]
2025-09-16 8:48 ` linux-next: build failure in the vfs tree kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMhzi0WpakpN7oH5@sirena.org.uk \
--to=broonie@kernel$(echo .)org \
--cc=amir73il@gmail$(echo .)com \
--cc=brauner@kernel$(echo .)org \
--cc=buildfailureaftermergeofthevfstree@sirena$(echo .)org.uk \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=viro@zeniv$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox