From: Tejun Heo <tj@kernel•org>
To: Thorsten Leemhuis <linux@leemhuis•info>
Cc: Nathan Chancellor <nathan@kernel•org>,
Ingo Molnar <mingo@kernel•org>,
Peter Zijlstra <peterz@infradead•org>,
vincent.guittot@linaro•org, linux-kernel@vger•kernel.org,
juri.lelli@redhat•com, dietmar.eggemann@arm•com,
rostedt@goodmis•org, bsegall@google•com, mgorman@suse•de,
vschneid@redhat•com, void@manifault•com, arighi@nvidia•com,
changwoo@igalia•com, sched-ext@lists•linux.dev,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: error: implicit declaration of function ‘rq_modified_clear’ (was [PATCH 5/5] sched: Rework sched_class::wakeup_preempt() and rq_modified_*())
Date: Tue, 16 Dec 2025 08:40:36 -1000 [thread overview]
Message-ID: <aUGnpH-WAneT-4RE@slm.duckdns.org> (raw)
In-Reply-To: <fdf21e40-b504-4122-a072-2c546b1f8237@leemhuis.info>
On Tue, Dec 16, 2025 at 08:02:50AM +0100, Thorsten Leemhuis wrote:
>
>
> On 12/15/25 12:51, Nathan Chancellor wrote:
> > On Mon, Dec 15, 2025 at 08:12:13AM +0100, Ingo Molnar wrote:
> >>
> >> * Thorsten Leemhuis <linux@leemhuis•info> wrote:
> >>
> >>> On 11/27/25 16:39, Peter Zijlstra wrote:
> >>>> Change sched_class::wakeup_preempt() to also get called for
> >>>> cross-class wakeups, specifically those where the woken task is of a
> >>>> higher class than the previous highest class.
> >>>
> >>> I suspect you might be aware of this already, but this patch afaics
> >>> broke compilation of today's -next for me, as reverting fixed things.
> >>
> >> Yeah, sorry about that, I fumbled a conflict resolution - should be
> >> fixed for tomorrow's -next.
> >
> > It looks like you cleared up the rq_modified_clear() error but
> > rq_modified_above() is still present in kernel/sched/ext.c.
>
> ...which afaics causes this build error in today's next:
>
> In file included from kernel/sched/build_policy.c:62:
> kernel/sched/ext.c: In function ‘do_pick_task_scx’:
> kernel/sched/ext.c:2470:27: error: implicit declaration of function ‘rq_modified_above’ [-Wimplicit-function-declaration]
> 2470 | if (!force_scx && rq_modified_above(rq, &ext_sched_class))
> | ^~~~~~~~~~~~~~~~~
> make[4]: *** [scripts/Makefile.build:287: kernel/sched/build_policy.o] Error 1
> make[3]: *** [scripts/Makefile.build:556: kernel/sched] Error 2
> make[3]: *** Waiting for unfinished jobs....
> make[2]: *** [scripts/Makefile.build:556: kernel] Error 2
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builddir/build/BUILD/kernel-6.19.0-build/kernel-next-20251216/linux-6.19.0-0.0.next.20251216.415.vanilla.fc44.x86_64/Makefile:2062: .] Error 2
> make: *** [Makefile:256: __sub-make] Error 2
Ingo, Peter, I can pull tip and resolve this from sched_ext side too but it
would probably be cleaner to resolve from tip side?
Tahnks.
--
tejun
next prev parent reply other threads:[~2025-12-16 18:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251127153943.696191429@infradead.org>
[not found] ` <20251127154725.901391274@infradead.org>
2025-12-15 6:07 ` error: implicit declaration of function ‘rq_modified_clear’ (was [PATCH 5/5] sched: Rework sched_class::wakeup_preempt() and rq_modified_*()) Thorsten Leemhuis
2025-12-15 7:12 ` Ingo Molnar
2025-12-15 11:51 ` Nathan Chancellor
2025-12-16 7:02 ` Thorsten Leemhuis
2025-12-16 18:40 ` Tejun Heo [this message]
2025-12-16 21:42 ` Peter Zijlstra
2025-12-17 9:58 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUGnpH-WAneT-4RE@slm.duckdns.org \
--to=tj@kernel$(echo .)org \
--cc=arighi@nvidia$(echo .)com \
--cc=bsegall@google$(echo .)com \
--cc=changwoo@igalia$(echo .)com \
--cc=dietmar.eggemann@arm$(echo .)com \
--cc=juri.lelli@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux@leemhuis$(echo .)info \
--cc=mgorman@suse$(echo .)de \
--cc=mingo@kernel$(echo .)org \
--cc=nathan@kernel$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=sched-ext@lists$(echo .)linux.dev \
--cc=vincent.guittot@linaro$(echo .)org \
--cc=void@manifault$(echo .)com \
--cc=vschneid@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox