From: Alessio Belle <Alessio.Belle@imgtec•com>
To: Matt Coster <Matt.Coster@imgtec•com>
Cc: "sfr@canb•auug.org.au" <sfr@canb•auug.org.au>,
"simona@ffwll•ch" <simona@ffwll•ch>,
"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>,
"tzimmermann@suse•de" <tzimmermann@suse•de>,
"dri-devel@lists•freedesktop.org"
<dri-devel@lists•freedesktop.org>,
"airlied@gmail•com" <airlied@gmail•com>,
Frank Binns <Frank.Binns@imgtec•com>,
"maarten.lankhorst@linux•intel.com"
<maarten.lankhorst@linux•intel.com>,
Alexandru Dadu <Alexandru.Dadu@imgtec•com>,
"mripard@kernel•org" <mripard@kernel•org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH v2] drm/imagination: Document pvr_device.power member
Date: Fri, 21 Nov 2025 16:43:56 +0000 [thread overview]
Message-ID: <ab6c81c2bb61dfd46bbc87b419c5555e6f34115d.camel@imgtec.com> (raw)
In-Reply-To: <20251121-device-power-doc-fix-v2-1-3417779f36c7@imgtec.com>
On Fri, 2025-11-21 at 15:20 +0000, Matt Coster wrote:
> Automated testing caught this missing doc comment; add something suitable
> (and useful).
>
> Fixes: 330e76d31697 ("drm/imagination: Add power domain control")
> Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
> Closes: https://lore.kernel.org/r/20251106152448.453b53ad@canb.auug.org.au/
> Signed-off-by: Matt Coster <matt.coster@imgtec•com>
Reviewed-by: Alessio Belle <alessio.belle@imgtec•com>
Thanks,
Alessio
> ---
> Based on the build target indicated in the report, I tried (and failed)
> to reproduce the reported warning using:
>
> make W=1 htmldocs
>
> I was, however, able to get the reported warning (and verify that this
> patch clears it) using:
>
> scripts/kernel-doc -none drivers/gpu/drm/imagination/pvr_device.h
>
> Does anyone have any ideas why my invocation of htmldocs didn't seem to
> have the same effect? Is it just simply that the relevant doc comment
> isn't pulled into any of the rst docs; in which case how did the
> linux-next build catch this warning?
>
> Changes in v2:
> - Add a proper commit description.
> - Link to v1: https://lore.kernel.org/r/20251106-device-power-doc-fix-v1-1-76d9841c8084@imgtec.com
> ---
> drivers/gpu/drm/imagination/pvr_device.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/imagination/pvr_device.h b/drivers/gpu/drm/imagination/pvr_device.h
> index ab8f56ae15df..ec53ff275541 100644
> --- a/drivers/gpu/drm/imagination/pvr_device.h
> +++ b/drivers/gpu/drm/imagination/pvr_device.h
> @@ -146,6 +146,14 @@ struct pvr_device {
> */
> struct clk *mem_clk;
>
> + /**
> + * @power: Optional power domain devices.
> + *
> + * On platforms with more than one power domain for the GPU, they are
> + * stored here in @domain_devs, along with links between them in
> + * @domain_links. The size of @domain_devs is given by @domain_count,
> + * while the size of @domain_links is (2 * @domain_count) - 1.
> + */
> struct pvr_device_power {
> struct device **domain_devs;
> struct device_link **domain_links;
>
> ---
> base-commit: cead55e24cf9e092890cf51c0548eccd7569defa
> change-id: 20251106-device-power-doc-fix-ba1a5d753b6f
>
next prev parent reply other threads:[~2025-11-21 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 15:20 [PATCH v2] drm/imagination: Document pvr_device.power member Matt Coster
2025-11-21 16:43 ` Alessio Belle [this message]
2025-11-21 17:12 ` Matt Coster
2025-11-22 0:29 ` Randy Dunlap
2025-11-22 3:46 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab6c81c2bb61dfd46bbc87b419c5555e6f34115d.camel@imgtec.com \
--to=alessio.belle@imgtec$(echo .)com \
--cc=Alexandru.Dadu@imgtec$(echo .)com \
--cc=Frank.Binns@imgtec$(echo .)com \
--cc=Matt.Coster@imgtec$(echo .)com \
--cc=airlied@gmail$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=mripard@kernel$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=simona@ffwll$(echo .)ch \
--cc=tzimmermann@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox