From: Hans de Goede <hdegoede@redhat•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
Mark Gross <mark.gross@intel•com>
Cc: Vadim Pasternak <vadimp@nvidia•com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the drivers-x86 tree
Date: Mon, 30 Nov 2020 08:43:21 +0100 [thread overview]
Message-ID: <ae231b40-e1c8-6995-d45b-ddab6a04810e@redhat.com> (raw)
In-Reply-To: <20201130044331.4abf7b91@canb.auug.org.au>
Hi Stephen,
On 11/29/20 6:43 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 912b341585e3 ("platform/x86: mlx-platform: Remove PSU EEPROM from MSN274x platform configuration")
>
> Fixes tag
>
> Fixes: ef08e14a3 ("platform/x86: mlx-platform: Add support for new msn274x system type")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
>
> In commit
>
> 2bf5046bdb64 ("platform/x86: mlx-platform: Remove PSU EEPROM from default platform configuration")
>
> Fixes tags
>
> Fixes: c6acad68e ("platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface")
> Fixes: ba814fdd0 ("platform/x86: mlx-platform: Use defines for bus assignment")
>
> have these problem(s):
>
> - SHA1 should be at least 12 digits long
Hmm, for some reason checkpatch did not catch these, while AFAIK it will complain
about short hashes in the normal part of the commit msg.
Question, how important is it to fix these ? I normally never do forced pushes
to the for-next branch. But if this is considered important to fix I guess I
can make an exception.
> These can be fixed in the future by setting core.abbrev to 12 (or more)
> or (for git v2.11 or later) just making sure it is not set (or set to
> "auto").
Will git rewrite the commit msg when this is set ? I'm at 2.28 and don't
have core.abbrev set. But I guess this needs to be set in the gitconfig
of the creator of the patch; and this has no impact on "git am" ?
Regards,
Hans
next prev parent reply other threads:[~2020-11-30 7:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-29 17:43 linux-next: Fixes tag needs some work in the drivers-x86 tree Stephen Rothwell
2020-11-30 7:43 ` Hans de Goede [this message]
2020-11-30 7:58 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2024-11-18 21:06 Stephen Rothwell
2024-11-20 14:02 ` Hans de Goede
2022-03-01 21:17 Stephen Rothwell
2022-03-02 11:17 ` Hans de Goede
2021-11-01 21:37 Stephen Rothwell
2021-11-02 10:28 ` Hans de Goede
2021-08-10 22:16 Stephen Rothwell
2021-08-12 7:40 ` Hans de Goede
2021-03-08 6:06 Stephen Rothwell
2021-03-08 10:36 ` Hans de Goede
2020-04-23 22:53 Stephen Rothwell
2020-04-24 9:46 ` Andy Shevchenko
2019-06-11 21:43 Stephen Rothwell
2019-04-16 21:33 Stephen Rothwell
2019-02-06 22:57 Stephen Rothwell
[not found] ` <38152c55-c2c1-c89f-2751-0ef0d40fcba9@linux.intel.com>
2019-02-07 15:55 ` Andy Shevchenko
2019-02-13 15:15 ` Bhardwaj, Rajneesh
2019-02-21 0:40 ` Darren Hart
2019-02-21 13:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae231b40-e1c8-6995-d45b-ddab6a04810e@redhat.com \
--to=hdegoede@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mark.gross@intel$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=vadimp@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox