Subject: Re: [PATCH v1] perf build: Fix fsmount.o build

From: Namhyung Kim <[email-masked]>
Date: Thu, 21 May 2026 09:51:56 -0700

Hi Ian,

On Thu, May 21, 2026 at 08:35:58AM -0700, Ian Rogers wrote:
> A merge conflict between:
> commit 552636b9317c8 ("perf trace: Add beautifier script for fsmount flags")
> commit 32969ef6e3e19 ("perf build: Pre-generate BPF skeleton tooling during umbrella prepare phase")
> Resulted in a missed build dependency in the merge:
> commit 61da860eee07 Merge branch 'perf-tools-next' of https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git
> 
> Fix the build by adding the necessary build dependencies.

Thanks for fixing this.  I believe the right fix would be to merge
perf-tools into perf-tools-next with this resolution.

Thanks,
Namhyung

> 
> Signed-off-by: Ian Rogers <[email-masked]>
> ---
>  tools/perf/trace/beauty/Build | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/trace/beauty/Build b/tools/perf/trace/beauty/Build
> index 93cde93461a3..996e63cdf765 100644
> --- a/tools/perf/trace/beauty/Build
> +++ b/tools/perf/trace/beauty/Build
> @@ -111,6 +111,13 @@ $(fsmount_arrays): $(beauty_uapi_linux_dir)/mount.h $(fsmount_tbls)
>  	$(call rule_mkdir)
>  	$(Q)$(call echo-cmd,gen)$(SHELL) '$(fsmount_tbls)' $(beauty_uapi_linux_dir) > $@
>  
> +fsmount_attr_arrays := $(beauty_outdir)/fsmount_attr_arrays.c
> +fsmount_attr_tbls := $(srctree)/tools/perf/trace/beauty/fsmount_attr.sh
> +
> +$(fsmount_attr_arrays): $(beauty_uapi_linux_dir)/mount.h $(fsmount_attr_tbls)
> +	$(call rule_mkdir)
> +	$(Q)$(call echo-cmd,gen)$(SHELL) '$(fsmount_attr_tbls)' $(beauty_uapi_linux_dir) > $@
> +
>  fspick_arrays := $(beauty_outdir)/fspick_arrays.c
>  fspick_tbls := $(srctree)/tools/perf/trace/beauty/fspick.sh
>  
> @@ -285,7 +292,7 @@ $(OUTPUT)trace/beauty/syscalltbl.o: $(syscall_array)
>  $(OUTPUT)trace/beauty/fsconfig.o: $(fsconfig_arrays)
>  $(OUTPUT)trace/beauty/clone.o: $(clone_flags_array)
>  $(OUTPUT)trace/beauty/fs_at_flags.o: $(fs_at_flags_array)
> -$(OUTPUT)trace/beauty/fsmount.o: $(fsmount_arrays)
> +$(OUTPUT)trace/beauty/fsmount.o: $(fsmount_arrays) $(fsmount_attr_arrays)
>  $(OUTPUT)trace/beauty/fspick.o: $(fspick_arrays)
>  $(OUTPUT)trace/beauty/ioctl.o: $(drm_ioctl_array) $(sndrv_pcm_ioctl_array) $(sndrv_ctl_ioctl_array) $(kvm_ioctl_array) $(vhost_virtio_ioctl_array) $(perf_ioctl_array) $(usbdevfs_ioctl_array)
>  $(OUTPUT)trace/beauty/kcmp.o: $(kcmp_type_array)
> -- 
> 2.54.0.746.g67dd491aae-goog
>