From: Xiong Zhou <jencce.kernel@gmail•com>
To: Mark Brown <broonie@opensource•wolfsonmicro.com>
Cc: Peter Hurley <peter@hurleysoftware•com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, Xiong Zhou <jencce.kernel@gmail•com>
Subject: Re: [PATCH -next] sound/soc/codecs: Mark snd-soc-wm2200 and snd-soc-wm-adsp as BROKEN
Date: Sat, 30 Mar 2013 20:30:39 +0800 (CST) [thread overview]
Message-ID: <alpine.DEB.2.02.1303302029231.25958@M2420> (raw)
In-Reply-To: <20130329185004.GL18316@opensource.wolfsonmicro.com>
On Fri, 29 Mar 2013, Mark Brown wrote:
> On Fri, Mar 29, 2013 at 02:45:54PM -0400, Peter Hurley wrote:
>
> > This is stock Ubuntu configs.
>
> Then the stock Ubuntu configuration is not a sensible one, enabling
> SND_SOC_ALL_CODECS for any purpose other than build coverage testing is
> just a waste of time - that's all it does.
>
Take a look at this:
MFD_ARIZONA_I2C select
> -------- > MFD_ARIZONA <-|
MDF_ARIZONA_SPI |
|
|depends on
|
|
SND_SOC_ALL_CODECS-\ / \
I2C ---------/| MFD_WM5110 MFD_WM5102
| | |
| |select | select
| | |
v v v
SND_SOC_WM2200 SND_SOC_WM5102 SND_SOC_WM5110
| | | |
|____________________| |___________|
| |
| if M/Y | if M/Y
v v
SND_SOC_WM_ADSP SND_SOC_ARIZONA
If I2C is enabled normally, and SND_SOC_ALL_CODECS is keeped in the
sound card configure options.
Then, disable ALL options in:
Device drivers ---->
Multifunction device drivers --->
which includes MFD_ARIZONA_I2C and MDF_ARIZONA_SPI.
So the failure comes. Yes, this config is kind of specific, not much.
The definition of one array which is cited by one module comes in
another module, and this dependence does not appear in Kconfig
architecture. Indeed, the help text of ALL_CODECS reminds the
separated surpporting bus options. Still I think this is unreasonable.
Even though build coverage test is the only proper purpose. It breaks
the whole building procedure.
I think copying the same array definition across c file is ugly, and Mark
said that this is not a Kconfig issue. So far, I have not got any other
idea to fix this. Code cruising.
next prev parent reply other threads:[~2013-03-30 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 14:12 [PATCH -next] sound/soc/codecs: Mark snd-soc-wm2200 and snd-soc-wm-adsp as BROKEN Peter Hurley
2013-03-29 17:12 ` Mark Brown
2013-03-29 18:45 ` Peter Hurley
2013-03-29 18:50 ` Mark Brown
2013-03-30 12:30 ` Xiong Zhou [this message]
2013-03-30 13:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1303302029231.25958@M2420 \
--to=jencce.kernel@gmail$(echo .)com \
--cc=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=peter@hurleysoftware$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox