From: Linus Torvalds <torvalds@linux-foundation•org>
To: Andrew Morton <akpm@linux-foundation•org>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Yinghai Lu <yhlu.kernel@gmail•com>
Subject: Re: linux-next: Tree for September 3
Date: Thu, 4 Sep 2008 01:02:10 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0809040045190.3378@nehalem.linux-foundation.org> (raw)
In-Reply-To: <20080903223318.84b6ce8b.akpm@linux-foundation.org>
On Wed, 3 Sep 2008, Andrew Morton wrote:
> On Wed, 3 Sep 2008 22:21:54 -0700 (PDT) Linus Torvalds <torvalds@linux-foundation•org> wrote:
> >
> > Can you apply this patch, just to see if it fixes things.
>
> Below..
>
> > And do you know when this started happening? It shouldn't have been all
> > that recent. Maybe you haven't tried your Vaio in a while?
>
> Yes, the Vaio had a vacation in New York. Last kernel it booted was
> 2.6.26-rc8-mm1.
>
> --- x 2008-09-03 21:38:24.000000000 -0700
> +++ y 2008-09-03 22:29:04.000000000 -0700
> ...
> @@ -503,15 +503,15 @@
> calling init_acpi_pm_clocksource+0x0/0x14a
> initcall init_acpi_pm_clocksource+0x0/0x14a returned 0 after 32 msecs
> calling pcibios_assign_resources+0x0/0x70
> -pci 0000:06:05.0: BAR 9 too large: 0x00000000000000-0x00000003ffffff
Ok, it fixed that particular thing, and now the mem windows look fine:
> pci 0000:06:05.0: CardBus bridge, secondary bus 0000:07
> pci 0000:06:05.0: IO window: 0x002400-0x0024ff
> pci 0000:06:05.0: IO window: 0x002800-0x0028ff
> -pci 0000:06:05.0: MEM window: 0x54000000-0x57ffffff
> +pci 0000:06:05.0: PREFETCH window: 0x50000000-0x53ffffff
> +pci 0000:06:05.0: MEM window: 0x58000000-0x5bffffff
so it fixed _one_ issue.
This also then changes the parent bus bridge:
> pci 0000:00:1e.0: PCI bridge, secondary bus 0000:06
> pci 0000:00:1e.0: IO window: 0x2000-0x2fff
> pci 0000:00:1e.0: MEM window: 0xb0100000-0xb01fffff
> -pci 0000:00:1e.0: PREFETCH window: disabled
> +pci 0000:00:1e.0: PREFETCH window: 0x00000050000000-0x00000053ffffff
ie it has now allocated a prefetch window in the parent PCI bridge too
in order to fit that cardbus bridge in.
So this all looks ok. I'd be happier if you also actually had some actual
_device_ in the Cardbus slot and reported that that works, but the patch
clearly
- fixes a very bogus alignment calculation
- actually fixes a Cardbus setup issue for you.
so I'll commit it.
> also...
>
> calling yenta_socket_init+0x0/0x16
> yenta_cardbus 0000:06:05.0: CardBus bridge found [104d:818f]
> -yenta_cardbus 0000:06:05.0: CardBus bridge, secondary bus 0000:07
> -yenta_cardbus 0000:06:05.0: IO window: 0x002400-0x0024ff
> -yenta_cardbus 0000:06:05.0: IO window: 0x002800-0x0028ff
> -yenta_cardbus 0000:06:05.0: PREFETCH window: 0x50400000-0x507fffff
> -yenta_cardbus 0000:06:05.0: MEM window: 0x54000000-0x57ffffff
these went away, because yenta_allocate_resources() will not try to
reprogram the controller if it's already been fully set up. So because
yenta_alloc_resources() is happy with the resource setup and leaves it
alone, there's no more noise about it.
So I would say that the PCI resource issue is fixed.
[ Side note: I actually suspect that your cardbus slot actually worked
fine _despite_ the problems, because
(a) the whole yenta_allocate_resources() -> pci_setup_cardbus() sequence
did end up setting things up correctly int he end, even if the
prefetchable memory resource ended up being in a non-prefetchable
area
(b) Very few cardbus cards would have any prefetchable resources, much
less care about the theoretical performance difference even if they
did.
but that allocation issue was still a bug ]
And you seem to have found your non-console problem separately.
Linus
next prev parent reply other threads:[~2008-09-04 8:02 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 9:16 linux-next: Tree for September 3 Stephen Rothwell
2008-09-04 2:32 ` [PATCH] hid: fix gyration build error Randy Dunlap
2008-09-04 6:52 ` Jiri Slaby
2008-09-04 8:06 ` Jiri Kosina
2008-09-04 4:42 ` linux-next: Tree for September 3 Andrew Morton
2008-09-04 4:46 ` Andrew Morton
2008-09-04 4:54 ` Andrew Morton
2008-09-04 4:57 ` Stephen Rothwell
2008-09-04 5:05 ` Andrew Morton
2008-09-04 5:20 ` Stephen Rothwell
2008-09-04 6:01 ` Andrew Morton
2008-09-04 7:15 ` Andrew Morton
2008-09-04 7:48 ` Stephen Rothwell
2008-09-04 9:19 ` Alan Cox
2008-09-04 9:21 ` Alan Cox
2008-09-04 11:01 ` Alan Cox
2008-09-04 14:35 ` Alan Cox
2008-09-04 5:26 ` Linus Torvalds
2008-09-04 5:42 ` Andrew Morton
2008-09-04 5:00 ` Stephen Rothwell
2008-09-04 5:21 ` Linus Torvalds
2008-09-04 5:33 ` Andrew Morton
2008-09-04 7:14 ` Yinghai Lu
2008-09-04 8:00 ` Andrew Morton
2008-09-04 8:23 ` Linus Torvalds
2008-09-04 8:02 ` Linus Torvalds [this message]
2008-09-04 8:25 ` Andrew Morton
2008-09-04 8:37 ` Andrew Morton
2008-09-04 9:03 ` Linus Torvalds
2008-09-04 8:50 ` Linus Torvalds
2008-09-04 8:57 ` Andrew Morton
2008-09-04 9:07 ` Linus Torvalds
2008-09-04 17:45 ` Andrew Morton
2008-09-04 18:05 ` Linus Torvalds
2008-09-04 18:34 ` Andrew Morton
2008-09-04 20:31 ` Eric W. Biederman
2008-09-04 20:41 ` Andrew Morton
2008-09-04 21:03 ` Eric W. Biederman
2008-09-04 22:22 ` Andrew Morton
2008-09-04 22:45 ` Thomas Gleixner
2008-09-04 23:17 ` Linus Torvalds
2008-09-05 5:39 ` Arjan van de Ven
2008-09-04 23:17 ` Andrew Morton
2008-09-04 23:25 ` Linus Torvalds
2008-09-04 23:27 ` Thomas Gleixner
2008-09-05 11:04 ` Ingo Molnar
2008-09-05 17:49 ` Andrew Morton
2008-09-09 4:39 ` Jesse Barnes
-- strict thread matches above, loose matches on Subject: below --
2009-09-03 11:59 Stephen Rothwell
2010-09-03 3:52 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0809040045190.3378@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=yhlu.kernel@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox