From: "Robert P. J. Day" <rpjday@crashcourse•ca>
To: Alexander Beregalov <a.beregalov@gmail•com>
Cc: gregkh@suse•de, linux-kernel@vger•kernel.org, linux-next@vger•kernel.org
Subject: Re: [PATCH] Staging: comedi: comedidev should include delay.h
Date: Thu, 21 May 2009 09:09:53 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0905210907440.3475@localhost.localdomain> (raw)
In-Reply-To: <1242911193-30469-1-git-send-email-a.beregalov@gmail.com>
On Thu, 21 May 2009, Alexander Beregalov wrote:
> Fix many build errors like this:
> comedi/drivers/adq12b.c:328: error: implicit declaration of function 'udelay'
>
> The same for aio_aio12_8.c, dmm32at.c and others.
>
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail•com>
> ---
> drivers/staging/comedi/comedidev.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index 7a1ccde..3d0e80c 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -38,6 +38,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/uaccess.h>
> #include <linux/io.h>
> +#include <linux/delay.h>
>
> #include "comedi.h"
not sure it's worth noting but the header comedidev.h currently
resides in the comedi directory itself, while the source file rt.c
contains:
#include <linux/comedidev.h>
which doesn't seem right. and that local comedidev.h header file
contains the comment:
/*
include/linux/comedidev.h
as if it *were* really under include/linux. perhaps someone would
like to clarify that. just an observation.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Linked In: http://www.linkedin.com/in/rpjday
Twitter: http://twitter.com/rpjday
========================================================================
next prev parent reply other threads:[~2009-05-21 13:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 13:06 [PATCH] Staging: comedi: comedidev should include delay.h Alexander Beregalov
2009-05-21 13:09 ` Robert P. J. Day [this message]
2009-05-21 13:55 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0905210907440.3475@localhost.localdomain \
--to=rpjday@crashcourse$(echo .)ca \
--cc=a.beregalov@gmail$(echo .)com \
--cc=gregkh@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox