From: David Woodhouse <dwmw2@infradead•org>
To: Ingo Molnar <mingo@elte•hu>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org, "Song,
Youquan" <youquan.song@intel•com>,
Suresh Siddha <suresh.b.siddha@intel•com>
Subject: Re: linux-next: manual merge of the dwmw2-iommu tree with Linus' tree
Date: Wed, 25 May 2011 11:57:06 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.02.1105251133001.3164@localhost6.localdomain6> (raw)
In-Reply-To: <20110525091636.GC28500@elte.hu>
On Wed, 25 May 2011, Ingo Molnar wrote:
> That particular change was still under discussion and i'm not at all
> sure we want to do it like that. So please repost the latest version.
I had not seen such discussion; I had the impression that having dealt
with my feedback about making the thing more visible to the user, Youquan
considered the patch complete.
I am more than happy to absolve responsibility for this patch altogether
and drop it from tree, though. It is *absolutely* the wrong approach, in
my opinion. If the BIOS is broken and cannot cope with x2apic, the
solution is to line the "engineers" responsible up against the wall and
shoot them. And then to implement a "quiesce all SMI" feature that the OS
can invoke, and make it mandatory. Presumably that's the underlying
problem they were trying to solve?
The answer certainly isn't to add a flag in the DMAR table to opt out of
x2apic use, when afaict the kernel is capable of using x2apic in some
cases even when the *is* no DMAR. (Either that, or we have a lot of dead
code in that area which *looks* like it copes with x2apic+!dmar).
I'll drop this patch from my tree when I get home and happily wash my
hands of it. It's all yours; have fun :)
--
dwmw2
next prev parent reply other threads:[~2011-05-25 10:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 3:00 linux-next: manual merge of the dwmw2-iommu tree with Linus' tree Stephen Rothwell
2011-05-25 9:16 ` Ingo Molnar
2011-05-25 10:57 ` David Woodhouse [this message]
2011-05-25 11:40 ` Ingo Molnar
2011-05-25 20:16 ` Youquan Song
2011-05-25 20:59 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1105251133001.3164@localhost6.localdomain6 \
--to=dwmw2@infradead$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=suresh.b.siddha@intel$(echo .)com \
--cc=youquan.song@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox