From: Ken Chen <kenchen@google•com>
To: Sam Ravnborg <sam@ravnborg•org>
Cc: Andrew Morton <akpm@linux-foundation•org>,
David Miller <davem@davemloft•net>,
sparclinux <sparclinux@vger•kernel.org>,
mingo@elte•hu, sfr@canb•auug.org.au,
linux-kernel@vger•kernel.org, paulus@samba•org,
tglx@linutronix•de, hpa@zytor•com, linux-next@vger•kernel.org
Subject: Re: [PATCH] sparc64: use unsigned long long for u64
Date: Tue, 23 Dec 2008 09:29:52 -0800 [thread overview]
Message-ID: <b040c32a0812230929u282f0f2bn9221bf2e176d82eb@mail.gmail.com> (raw)
In-Reply-To: <20081223172610.GA5957@uranus.ravnborg.org>
On Tue, Dec 23, 2008 at 9:26 AM, Sam Ravnborg <sam@ravnborg•org> wrote:
>> wait, why does this need to be changed?
>
> We have:
> clocksource_tick.read = tick_ops->get_tick;
>
> And clocksource_tick is of type clocksource:
>
> struct clocksource {
> ...
> cycle_t (*read)(void);
>
> And cycle_t is:
> /* clocksource cycle base type */
> typedef u64 cycle_t;
>
> And u64 is now:
> unsigned long long - thus we need to fix prototype
> of get_tick to fix the warnings.
>
> A cast could do it - but fixing the real problem
> is better here.
Sounds good to me. It was just a question. Thank you for the explanation.
- Ken
next prev parent reply other threads:[~2008-12-23 17:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-22 4:22 linux-next: sched tree build warning Stephen Rothwell
2008-12-22 6:47 ` Ingo Molnar
2008-12-22 6:49 ` Ken Chen
2008-12-22 7:04 ` Ingo Molnar
2008-12-22 7:19 ` Stephen Rothwell
2008-12-22 8:03 ` [patch] powerpc: change u64/s64 to a long long integer type Ingo Molnar
2008-12-22 22:43 ` Andrew Morton
2008-12-22 23:00 ` Sam Ravnborg
2008-12-22 23:03 ` H. Peter Anvin
2008-12-22 23:13 ` Sam Ravnborg
2008-12-22 23:13 ` Andrew Morton
2008-12-23 13:17 ` [PATCH] sparc64: use unsigned long long for u64 Sam Ravnborg
2008-12-23 14:42 ` [PATCH] sparc64: fix unsigned long long warnings in drivers Sam Ravnborg
2008-12-23 17:05 ` [PATCH] sparc64: use unsigned long long for u64 Ken Chen
2008-12-23 17:26 ` Sam Ravnborg
2008-12-23 17:29 ` Ken Chen [this message]
2008-12-23 17:34 ` Sam Ravnborg
2008-12-27 8:54 ` David Miller
2008-12-27 9:24 ` Sam Ravnborg
2008-12-27 9:37 ` David Miller
2008-12-27 9:49 ` Sam Ravnborg
2008-12-28 4:25 ` David Miller
2008-12-28 12:32 ` Sam Ravnborg
2008-12-31 4:40 ` [patch] powerpc: change u64/s64 to a long long integer type Stephen Rothwell
2008-12-31 7:52 ` Ingo Molnar
2008-12-22 8:14 ` linux-next: sched tree build warning Paul Mackerras
2008-12-22 8:18 ` Ingo Molnar
2008-12-22 9:44 ` Paul Mackerras
2008-12-22 10:53 ` Ingo Molnar
2008-12-22 12:03 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b040c32a0812230929u282f0f2bn9221bf2e176d82eb@mail.gmail.com \
--to=kenchen@google$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=hpa@zytor$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=paulus@samba$(echo .)org \
--cc=sam@ravnborg$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox