Subject: Re: linux-next: Tree for May 15 (config SERIAL_CPM)

From: Jiri Slaby <[email-masked]>
Date: Thu, 18 May 2023 07:49:41 +0200

On 16. 05. 23, 4:51, Randy Dunlap wrote:
> 
> 
> On 5/14/23 21:12, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20230512:
>>
> 
> commit e3e7b13bffae
> Author: Jiri Slaby <[email-masked]>
> Date:   Thu Apr 21 12:17:08 2022 +0200
> 
>      serial: allow COMPILE_TEST for some drivers

That commit should be reverted. I didn't realize it wouldn't link, while 
it compiles fine.

> See this portion of that commit:
> 
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -783,7 +783,7 @@ config SERIAL_PMACZILOG_CONSOLE
>   
>   config SERIAL_CPM
>          tristate "CPM SCC/SMC serial port support"
> -       depends on CPM2 || CPM1
> +       depends on CPM2 || CPM1 || (PPC32 && COMPILE_TEST)
> 
> 
> When PPC32=y and COMPILE_TEST=y but CPM1 is not set and CPM2 is not set:
> 
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_release_port':
> cpm_uart_core.c:(.text+0x598): undefined reference to `cpm_uart_freebuf'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_set_termios':
> cpm_uart_core.c:(.text+0x8e0): undefined reference to `__cpm2_setbrg'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_break_ctl':
> cpm_uart_core.c:(.text+0xb10): undefined reference to `cpm_line_cr_cmd'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0xb6c): undefined reference to `cpm_line_cr_cmd'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_startup':
> cpm_uart_core.c:(.text+0x1d48): undefined reference to `cpm_line_cr_cmd'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_request_port':
> cpm_uart_core.c:(.text+0x1ddc): undefined reference to `cpm_uart_allocbuf'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2170): undefined reference to `cpm_line_cr_cmd'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_probe':
> cpm_uart_core.c:(.text+0x2474): undefined reference to `cpm_uart_map_pram'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2724): undefined reference to `cpm_uart_unmap_pram'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2838): undefined reference to `cpm_uart_map_pram'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_shutdown':
> cpm_uart_core.c:(.text+0x2aa8): undefined reference to `cpm_line_cr_cmd'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2ba4): undefined reference to `cpm_line_cr_cmd'
> 
> 

-- 
js
suse labs