From: Michal Wilczynski <m.wilczynski@samsung•com>
To: "Stephen Rothwell" <sfr@canb•auug.org.au>,
"Uwe Kleine-König" <ukleinek@kernel•org>
Cc: Danilo Krummrich <dakr@kernel•org>,
Boqun Feng <boqun.feng@gmail•com>,
Daniel Almeida <daniel.almeida@collabora•com>,
Peter Colberg <pcolberg@redhat•com>,
Lyude Paul <lyude@redhat•com>, Miguel Ojeda <ojeda@kernel•org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the pwm tree
Date: Mon, 27 Oct 2025 09:36:32 +0100 [thread overview]
Message-ID: <b81e9451-f363-4adf-9b20-e2e9bb55b92d@samsung.com> (raw)
In-Reply-To: <20251027125148.7f7d8ed6@canb.auug.org.au>
On 10/27/25 02:51, Stephen Rothwell wrote:
> Hi all,
>
> After merging the pwm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> error[E0277]: the trait bound `core::result::Result<core::pin::Pin<Box<Th1520PwmPlatformDriver, Kmalloc>>, kernel::error::Error>: PinInit<Th1520PwmPlatformDriver, kernel::error::Error>` is not satisfied
> --> drivers/pwm/pwm_th1520.rs:331:10
> |
> 331 | ) -> Result<Pin<KBox<Self>>> {
> | ^^^^^^^^^^^^^^^^^^^^^^^ unsatisfied trait bound
> |
> = help: the trait `PinInit<Th1520PwmPlatformDriver, kernel::error::Error>` is not implemented for `Result<Pin<Box<Th1520PwmPlatformDriver, Kmalloc>>, Error>`
> but trait `PinInit<core::pin::Pin<Box<Th1520PwmPlatformDriver, Kmalloc>>, kernel::error::Error>` is implemented for it
> = help: for that trait implementation, expected `core::pin::Pin<Box<Th1520PwmPlatformDriver, Kmalloc>>`, found `Th1520PwmPlatformDriver`
> note: required by a bound in `kernel::platform::Driver::{synthetic#0}`
> --> rust/kernel/platform.rs:196:15
> |
> 196 | ) -> impl PinInit<Self, Error>;
> | ^^^^^^^^^^^^^^^^^^^^ required by this bound in `Driver::{synthetic#0}`
>
> error: aborting due to 1 previous error
>
> For more information about this error, try `rustc --explain E0277`.
>
> Caused by commit
>
> fb3957af9ec6 ("pwm: Add Rust driver for T-HEAD TH1520 SoC")
>
> presumably interacting with something merged earlier in my tree.
> If someone could provide me with an appropriate merge resolution, I will
> apply it.
>
> I have used the pwm tree from next-20251024 for today.
>
Hi,
I believe this would fix the problem:
diff --git a/drivers/pwm/pwm_th1520.rs b/drivers/pwm/pwm_th1520.rs
index 0ad38b78be85..dd554574adc8 100644
--- a/drivers/pwm/pwm_th1520.rs
+++ b/drivers/pwm/pwm_th1520.rs
@@ -328,7 +328,7 @@ impl platform::Driver for Th1520PwmPlatformDriver {
fn probe(
pdev: &platform::Device<Core>,
_id_info: Option<&Self::IdInfo>,
- ) -> Result<Pin<KBox<Self>>> {
+ ) -> impl PinInit<Self, Error> {
let dev = pdev.as_ref();
let request = pdev.io_request_by_index(0).ok_or(ENODEV)?;
@@ -365,7 +365,7 @@ fn probe(
pwm::Registration::register(dev, chip)?;
- Ok(KBox::new(Th1520PwmPlatformDriver, GFP_KERNEL)?.into())
+ Ok(Th1520PwmPlatformDriver)
}
}
This is caused by change in fn probe, caused by this commit [1].
[1] - https://lore.kernel.org/all/20251016125544.15559-1-dakr@kernel.org/
Best regards,
--
Michal Wilczynski <m.wilczynski@samsung•com>
next prev parent reply other threads:[~2025-10-27 8:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20251027015241eucas1p1784b974d0c150e8c3513f32401205669@eucas1p1.samsung.com>
2025-10-27 1:51 ` linux-next: build failure after merge of the pwm tree Stephen Rothwell
2025-10-27 8:11 ` Uwe Kleine-König
2025-10-27 9:38 ` Danilo Krummrich
2025-10-28 1:51 ` Stephen Rothwell
2025-12-05 3:33 ` Stephen Rothwell
2025-10-27 13:40 ` Uwe Kleine-König
2025-10-27 13:49 ` Danilo Krummrich
2025-10-28 9:52 ` linux-next: build failure after merge of the pwm tree' Alice Ryhl
2025-10-27 8:36 ` Michal Wilczynski [this message]
2023-12-21 5:58 linux-next: build failure after merge of the pwm tree Stephen Rothwell
2023-12-21 9:25 ` Thierry Reding
2023-12-21 10:09 ` Lee Jones
2023-12-21 12:13 ` Sean Young
2023-12-21 12:51 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2019-01-12 6:01 Stephen Rothwell
2019-01-12 6:08 ` Stephen Rothwell
2019-01-12 15:27 ` Uwe Kleine-König
2014-08-22 21:07 Stephen Rothwell
2014-08-22 22:06 ` Thierry Reding
2014-08-22 22:15 ` Thierry Reding
2014-08-22 22:30 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b81e9451-f363-4adf-9b20-e2e9bb55b92d@samsung.com \
--to=m.wilczynski@samsung$(echo .)com \
--cc=boqun.feng@gmail$(echo .)com \
--cc=dakr@kernel$(echo .)org \
--cc=daniel.almeida@collabora$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=lyude@redhat$(echo .)com \
--cc=ojeda@kernel$(echo .)org \
--cc=pcolberg@redhat$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=ukleinek@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox