Subject: Re: [PATCH] of: fix htmldocs build warning

From: Randy Dunlap <[email-masked]>
Date: Thu, 9 Mar 2023 20:52:57 -0800

On 3/9/23 16:32, Stephen Rothwell wrote:
> 
> Fix this htmldoc build warning:
> 
> include/linux/of.h:115: warning: cannot understand function prototype: 'const struct kobj_type of_node_ktype; '
> 
> Reported by: Stephen Rothwell <[email-masked]>
> Fixes: 39459ce717b8 ("of: dynamic: add lifecycle docbook info to node creation functions")
> Signed-off-by: Stephen Rothwell <[email-masked]>

Acked-by: Randy Dunlap <[email-masked]>
Tested-by: Randy Dunlap <[email-masked]>
Thanks.

After this patch, there is another warning for this function:

../include/linux/of.h:118: warning: Excess function parameter 'phandle_name' description in 'of_node_init'

> ---
>  include/linux/of.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> This is actually untested, but seems pretty straight forward.
> 
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 0af611307db2..814d33f3835a 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -100,6 +100,9 @@ struct of_reconfig_data {
>  	struct property		*old_prop;
>  };
>  
> +extern const struct kobj_type of_node_ktype;
> +extern const struct fwnode_operations of_fwnode_ops;
> +
>  /**
>   * of_node_init - initialize a devicetree node
>   * @node: Pointer to device node that has been created by kzalloc()
> @@ -111,9 +114,6 @@ struct of_reconfig_data {
>   * whether to free the memory will be done by node->release(), which is
>   * of_node_release().
>   */
> -/* initialize a node */
> -extern const struct kobj_type of_node_ktype;
> -extern const struct fwnode_operations of_fwnode_ops;
>  static inline void of_node_init(struct device_node *node)
>  {
>  #if defined(CONFIG_OF_KOBJ)

-- 
~Randy