From: simon@mungewell•org
Cc: linux-input@vger•kernel.org, rdunlap@xenotime•net,
linux-next@vger•kernel.org, jkosina@suse•cz,
linux-kernel@vger•kernel.org,
David Herrmann <dh.herrmann@googlemail•com>
Subject: Re: [PATCH] HID: wiimote: Select INPUT_FF_MEMLESS
Date: Wed, 7 Dec 2011 16:07:38 -0500 [thread overview]
Message-ID: <b92a2d1d30910b75f3354926d9fa26f6.squirrel@host171.canaca.com> (raw)
In-Reply-To: <1323290039-28073-1-git-send-email-dh.herrmann@googlemail.com>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index edf2b2b..dae04a0 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -591,6 +591,7 @@ config HID_WIIMOTE
> depends on BT_HIDP
> depends on LEDS_CLASS
> select POWER_SUPPLY
> + select INPUT_FF_MEMLESS
> ---help---
> Support for the Nintendo Wii Remote bluetooth device.
I don't mean to be a complainer, but shouldn't the WiiMote module depend
on FF_MEMLESS rather than just forcing it on.
The module could also #define the appropriate bits so that FF_MEMLESS was
only used when available, the rumble motor is a very small part of the
WiiMote's feature set.
Some people might not want FF_MEMLESS enabled.
Simon.
next prev parent reply other threads:[~2011-12-07 21:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 6:12 linux-next: Tree for Dec 7 Stephen Rothwell
2011-12-07 10:39 ` Sasha Levin
2011-12-07 19:59 ` Sasha Levin
2011-12-07 19:10 ` linux-next: Tree for Dec 7 (x86, not SMP) Randy Dunlap
2011-12-07 19:42 ` Don Zickus
2011-12-07 20:43 ` Randy Dunlap
2011-12-07 21:06 ` Don Zickus
2011-12-08 2:45 ` Randy Dunlap
2011-12-07 20:41 ` linux-next: Tree for Dec 7 (kvm) Randy Dunlap
2011-12-07 20:53 ` linux-next: Tree for Dec 7 (hid/hid-wiimote) Randy Dunlap
2011-12-07 20:33 ` [PATCH] HID: wiimote: Select INPUT_FF_MEMLESS David Herrmann
2011-12-07 21:07 ` simon [this message]
2011-12-08 8:31 ` David Herrmann
2011-12-08 16:23 ` simon
2011-12-08 22:43 ` Sean Young
2011-12-07 21:51 ` Randy Dunlap
2011-12-11 23:27 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b92a2d1d30910b75f3354926d9fa26f6.squirrel@host171.canaca.com \
--to=simon@mungewell$(echo .)org \
--cc=dh.herrmann@googlemail$(echo .)com \
--cc=jkosina@suse$(echo .)cz \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rdunlap@xenotime$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox