From: Danilo Krummrich <dakr@kernel•org>
To: Thorsten Leemhuis <linux@leemhuis•info>
Cc: gregkh@linuxfoundation•org, rafael@kernel•org,
bhelgaas@google•com, kwilczynski@kernel•org,
david.m.ertman@intel•com, ira.weiny@intel•com, leon@kernel•org,
acourbot@nvidia•com, ojeda@kernel•org, alex.gaynor@gmail•com,
boqun.feng@gmail•com, gary@garyguo•net, bjorn3_gh@protonmail•com,
lossin@kernel•org, a.hindborg@kernel•org, aliceryhl@google•com,
tmgross@umich•edu, pcolberg@redhat•com,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
rust-for-linux@vger•kernel.org, linux-pci@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: Build error on -next in rust/kernel/usb.rs:92:34
Date: Mon, 3 Nov 2025 11:49:47 +0100 [thread overview]
Message-ID: <bebb6b2b-869d-4931-adb3-de5a2a201401@kernel.org> (raw)
In-Reply-To: <1c8afbc0-e888-4702-9e4e-fa8aef0f97ae@leemhuis.info>
On 11/3/25 7:43 AM, Thorsten Leemhuis wrote:
> """
> error[E0599]: no method named `data` found for struct `core::pin::Pin<kbox::Box<T, Kmalloc>>` in the current scope
> --> rust/kernel/usb.rs:92:34
> |
> 92 | T::disconnect(intf, data.data());
> | ^^^^ method not found in `core::pin::Pin<kbox::Box<T, Kmalloc>>`
>
> error: aborting due to 1 previous error
>
> For more information about this error, try `rustc --explain E0599`.
> make[2]: *** [rust/Makefile:553: rust/kernel.o] Error 1
> make[1]: *** [/builddir/build/BUILD/kernel-6.18.0-build/kernel-next-20251103/linux-6.18.0-0.0.next.20251103.436.vanilla.fc44.x86_64/Makefile:1316: prepare] Error 2
> make: *** [Makefile:256: __sub-make] Error 2
> """
>
> Full log:
> https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/next/fedora-rawhide-aarch64/09759703-next-next-all/builder-live.log.gz
>
> A quick search for "T::disconnect(intf, data.data());" on lore
> lead me here:
>
>> diff --git a/rust/kernel/usb.rs b/rust/kernel/usb.rs
>> index 9238b96c2185..05eed3f4f73e 100644
>> --- a/rust/kernel/usb.rs
>> +++ b/rust/kernel/usb.rs
>> @@ -87,9 +87,9 @@ extern "C" fn disconnect_callback(intf: *mut bindings::usb_interface) {
>> // SAFETY: `disconnect_callback` is only ever called after a successful call to
>> // `probe_callback`, hence it's guaranteed that `Device::set_drvdata()` has been called
>> // and stored a `Pin<KBox<T>>`.
>> - let data = unsafe { dev.drvdata_obtain::<Pin<KBox<T>>>() };
>> + let data = unsafe { dev.drvdata_obtain::<T>() };
>>
>> - T::disconnect(intf, data.as_ref());
>> + T::disconnect(intf, data.data());
>> }
>> }
This error is cause by commit 6bbaa93912bf ("rust: device: narrow the generic of
drvdata_obtain()").
It seems it slipped through, since the USB abstractions are disabled in all
trees other than the USB tree. I tested with enabling them locally, but it seems
I forgot to re-enable them after a rebase etc.
I will send a patch with the following fix:
diff --git a/rust/kernel/usb.rs b/rust/kernel/usb.rs
index 92215fdc3c6a..534e3ded5442 100644
--- a/rust/kernel/usb.rs
+++ b/rust/kernel/usb.rs
@@ -89,7 +89,7 @@ extern "C" fn disconnect_callback(intf: *mut
bindings::usb_interface) {
// and stored a `Pin<KBox<T>>`.
let data = unsafe { dev.drvdata_obtain::<T>() };
- T::disconnect(intf, data.data());
+ T::disconnect(intf, data.as_ref());
}
}
prev parent reply other threads:[~2025-11-03 10:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251020223516.241050-1-dakr@kernel.org>
[not found] ` <20251020223516.241050-2-dakr@kernel.org>
2025-11-03 6:43 ` Build error on -next in rust/kernel/usb.rs:92:34 (was: Re: [PATCH 1/8] rust: device: narrow the generic of drvdata_obtain()) Thorsten Leemhuis
2025-11-03 10:49 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bebb6b2b-869d-4931-adb3-de5a2a201401@kernel.org \
--to=dakr@kernel$(echo .)org \
--cc=a.hindborg@kernel$(echo .)org \
--cc=acourbot@nvidia$(echo .)com \
--cc=alex.gaynor@gmail$(echo .)com \
--cc=aliceryhl@google$(echo .)com \
--cc=bhelgaas@google$(echo .)com \
--cc=bjorn3_gh@protonmail$(echo .)com \
--cc=boqun.feng@gmail$(echo .)com \
--cc=david.m.ertman@intel$(echo .)com \
--cc=gary@garyguo$(echo .)net \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=ira.weiny@intel$(echo .)com \
--cc=kwilczynski@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux@leemhuis$(echo .)info \
--cc=lossin@kernel$(echo .)org \
--cc=ojeda@kernel$(echo .)org \
--cc=pcolberg@redhat$(echo .)com \
--cc=rafael@kernel$(echo .)org \
--cc=rust-for-linux@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tmgross@umich$(echo .)edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox