From: "Nirujogi, Pratap" <pnirujog@amd•com>
To: "Mario Limonciello" <mario.limonciello@amd•com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux•intel.com>,
"Pratap Nirujogi" <pratap.nirujogi@amd•com>
Cc: rdunlap@infradead•org, Hans de Goede <hdegoede@redhat•com>,
sfr@canb•auug.org.au, linux-next@vger•kernel.org,
platform-driver-x86@vger•kernel.org,
LKML <linux-kernel@vger•kernel.org>,
benjamin.chan@amd•com, bin.du@amd•com,
gjorgji.rosikopulos@amd•com, king.li@amd•com, dantony@amd•com
Subject: Re: [PATCH 3/3] platform/x86: Use i2c adapter name to fix build errors
Date: Tue, 3 Jun 2025 11:50:05 -0400 [thread overview]
Message-ID: <bf99824e-5113-47b6-931c-819fd6b1a6df@amd.com> (raw)
In-Reply-To: <91b4b206-e518-43ab-b6da-ce337f5a348c@amd.com>
On 6/3/2025 12:46 AM, Mario Limonciello wrote:
> On 6/2/2025 10:35 PM, Nirujogi, Pratap wrote:
>> Hi Ilpo,
>>
>> On 5/31/2025 1:11 AM, Ilpo Järvinen wrote:
>>> Caution: This message originated from an External Source. Use proper
>>> caution when opening attachments, clicking links, or responding.
>>>
>>>
>>> On Fri, 30 May 2025, Pratap Nirujogi wrote:
>>>
>>>> Use 'adapater->name' inplace of 'adapter->owner->name' to fix build
>>>> issues
>>>> when CONFIG_MODULES is not defined.
>>>>
>>>> Fixes: 90b85567e457 ("platform/x86: Add AMD ISP platform config for
>>>> OV05C10")
>>>
>>> This is the which should have this Fixes tag, the other commits
>>> should not
>>> have it as they're not really the fix (but this change just depends on
>>> them, but since stable is not in picture yet for this driver we don't
>>> need to indicate even those deps).
>>>
>> Thank you, I will take care of keeping the Fixes tag only in the x86/
>> platform driver patch and will remove in the other two i2c driver
>> patches.
>>
>> Sorry I think I'm not completely clear on this statement "we don't
>> need to indicate even those deps" - Am I good if I submit the same
>> patch series removing the Fixes tag from the two i2c driver patches?
>> Or Is it about submitting the i2c patches independently from x86/
>> platform, instead of keeping all the 3 patches in a single series. Can
>> you please help to clarify?
>
> Keep the patches in the series, but the only one that needs a Fixes tag
> is this one.
>
>>
>>>> Reported-by: Randy Dunlap <rdunlap@infradead•org>
>>>> Link: https://lore.kernel.org/all/04577a46-9add-420c-
>>>> b181-29bad582026d@infradead•org
>>>> Signed-off-by: Pratap Nirujogi <pratap.nirujogi@amd•com>
>>>> ---
>>>> drivers/platform/x86/amd/amd_isp4.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/platform/x86/amd/amd_isp4.c b/drivers/platform/
>>>> x86/amd/amd_isp4.c
>>>> index 0cc01441bcbb..80b57b58621a 100644
>>>> --- a/drivers/platform/x86/amd/amd_isp4.c
>>>> +++ b/drivers/platform/x86/amd/amd_isp4.c
>>>> @@ -151,7 +151,7 @@ MODULE_DEVICE_TABLE(acpi, amdisp_sensor_ids);
>>>>
>>>> static inline bool is_isp_i2c_adapter(struct i2c_adapter *adap)
>>>> {
>>>> - return !strcmp(adap->owner->name, "i2c_designware_amdisp");
>>>> + return !strcmp(adap->name, "AMDISP DesignWare I2C adapter");
>>>
>>> Since both are in-kernel code, share that name through a define in some
>>> header.
>>>
Thanks Mario for clarifying, will take care of it in the next v2 patch
series.
>> sure, I will find the header file that can be used to add the adap-
>> >name definition.
>>
>> Thanks,
>> Pratap
>>
>>> --
>>> i.
>>>
>>
>>
>
next prev parent reply other threads:[~2025-06-03 15:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 19:59 [PATCH 0/3] Fix build issue when CONFIG_MODULES is not set Pratap Nirujogi
2025-05-30 19:59 ` [PATCH 1/3] i2c: designware: Initialize adapter name only when " Pratap Nirujogi
2025-05-31 5:14 ` Ilpo Järvinen
2025-06-03 3:18 ` Nirujogi, Pratap
2025-05-30 19:59 ` [PATCH 2/3] i2c: amd-isp: Initialize unique adpater name Pratap Nirujogi
2025-05-31 5:06 ` Ilpo Järvinen
2025-06-03 3:15 ` Nirujogi, Pratap
2025-05-30 19:59 ` [PATCH 3/3] platform/x86: Use i2c adapter name to fix build errors Pratap Nirujogi
2025-05-31 5:11 ` Ilpo Järvinen
2025-06-03 3:35 ` Nirujogi, Pratap
2025-06-03 4:46 ` Mario Limonciello
2025-06-03 15:50 ` Nirujogi, Pratap [this message]
2025-06-03 7:15 ` Ilpo Järvinen
2025-06-03 15:50 ` Nirujogi, Pratap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf99824e-5113-47b6-931c-819fd6b1a6df@amd.com \
--to=pnirujog@amd$(echo .)com \
--cc=benjamin.chan@amd$(echo .)com \
--cc=bin.du@amd$(echo .)com \
--cc=dantony@amd$(echo .)com \
--cc=gjorgji.rosikopulos@amd$(echo .)com \
--cc=hdegoede@redhat$(echo .)com \
--cc=ilpo.jarvinen@linux$(echo .)intel.com \
--cc=king.li@amd$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mario.limonciello@amd$(echo .)com \
--cc=platform-driver-x86@vger$(echo .)kernel.org \
--cc=pratap.nirujogi@amd$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox