From: Christian Borntraeger <borntraeger@de•ibm.com>
To: "Michael S. Tsirkin" <mst@redhat•com>
Cc: "virtualization@lists•linux-foundation.org"
<virtualization@lists•linux-foundation.org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
kvm list <kvm@vger•kernel.org>, Halil Pasic <pasic@linux•ibm.com>
Subject: Re: vhost changes (batched) in linux-next after 12/13 trigger random crashes in KVM guests after reboot
Date: Tue, 7 Jan 2020 12:34:50 +0100 [thread overview]
Message-ID: <c6795e53-d12c-0709-c2e9-e35d9af1f693@de.ibm.com> (raw)
In-Reply-To: <20200107042401-mutt-send-email-mst@kernel.org>
On 07.01.20 10:39, Michael S. Tsirkin wrote:
> On Tue, Jan 07, 2020 at 09:59:16AM +0100, Christian Borntraeger wrote:
>>
>>
>> On 06.01.20 11:50, Michael S. Tsirkin wrote:
>>> On Wed, Dec 18, 2019 at 04:59:02PM +0100, Christian Borntraeger wrote:
>>>> On 18.12.19 16:10, Michael S. Tsirkin wrote:
>>>>> On Wed, Dec 18, 2019 at 03:43:43PM +0100, Christian Borntraeger wrote:
>>>>>> Michael,
>>>>>>
>>>>>> with
>>>>>> commit db7286b100b503ef80612884453bed53d74c9a16 (refs/bisect/skip-db7286b100b503ef80612884453bed53d74c9a16)
>>>>>> vhost: use batched version by default
>>>>>> plus
>>>>>> commit 6bd262d5eafcdf8cdfae491e2e748e4e434dcda6 (HEAD, refs/bisect/bad)
>>>>>> Revert "vhost/net: add an option to test new code"
>>>>>> to make things compile (your next tree is not easily bisectable, can you fix that as well?).
>>>>>
>>>>> I'll try.
>>>>>
>>>>>>
>>>>>> I get random crashes in my s390 KVM guests after reboot.
>>>>>> Reverting both patches together with commit decd9b8 "vhost: use vhost_desc instead of vhost_log" to
>>>>>> make it compile again) on top of linux-next-1218 makes the problem go away.
>>>>>>
>>>>>> Looks like the batched version is not yet ready for prime time. Can you drop these patches until
>>>>>> we have fixed the issues?
>>>>>>
>>>>>> Christian
>>>>>>
>>>>>
>>>>> Will do, thanks for letting me know.
>>>>
>>>> I have confirmed with the initial reporter (internal test team) that <driver name='qemu'/>
>>>> with a known to be broken linux next kernel also fixes the problem, so it is really the
>>>> vhost changes.
>>>
>>> OK I'm back and trying to make it more bisectable.
>>>
>>> I pushed a new tag "batch-v2".
>>> It's same code but with this bisect should get more information.
>>
>> I get the following with this tag
>>
>> drivers/vhost/net.c: In function ‘vhost_net_tx_get_vq_desc’:
>> drivers/vhost/net.c:574:7: error: implicit declaration of function ‘vhost_get_vq_desc_batch’; did you mean ‘vhost_get_vq_desc’? [-Werror=implicit-function-declaration]
>> 574 | r = vhost_get_vq_desc_batch(tvq, tvq->iov, ARRAY_SIZE(tvq->iov),
>> | ^~~~~~~~~~~~~~~~~~~~~~~
>> | vhost_get_vq_desc
>>
>
> Not sure why but I pushed a wrong commit. Sorry. Should be good now.
>
during bisect:
drivers/vhost/vhost.c: In function ‘vhost_get_vq_desc_batch’:
drivers/vhost/vhost.c:2634:8: error: ‘id’ undeclared (first use in this function); did you mean ‘i’?
2634 | ret = id;
| ^~
| i
I changed that to i
The last step then gave me (on commit 50297a8480b439efc5f3f23088cb2d90b799acef vhost: use batched version by default)
net enc1: Unexpected TXQ (0) queue failure: -5
in the guest.
bisect log so far:
[cborntra@m83lp52 linux]$ git bisect log
git bisect start
# bad: [3131e79bb9e9892a5a6bd33513de9bc90b20e867] vhost: use vhost_desc instead of vhost_log
git bisect bad 3131e79bb9e9892a5a6bd33513de9bc90b20e867
# good: [d1281e3a562ec6a08f944a876481dd043ba739b9] virtio-blk: remove VIRTIO_BLK_F_SCSI support
git bisect good d1281e3a562ec6a08f944a876481dd043ba739b9
# good: [5b00aab5b6332a67e32dace1dcd3a198ab94ed56] vhost: option to fetch descriptors through an independent struct
git bisect good 5b00aab5b6332a67e32dace1dcd3a198ab94ed56
# good: [5b00aab5b6332a67e32dace1dcd3a198ab94ed56] vhost: option to fetch descriptors through an independent struct
git bisect good 5b00aab5b6332a67e32dace1dcd3a198ab94ed56
# bad: [1414d7ee3d10d2ec2bc4ee652d1d90ec91da1c79] vhost: batching fetches
git bisect bad 1414d7ee3d10d2ec2bc4ee652d1d90ec91da1c79
next prev parent reply other threads:[~2020-01-07 11:35 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 14:43 vhost changes (batched) in linux-next after 12/13 trigger random crashes in KVM guests after reboot Christian Borntraeger
2019-12-18 15:10 ` Michael S. Tsirkin
2019-12-18 15:59 ` Christian Borntraeger
2020-01-06 10:50 ` Michael S. Tsirkin
2020-01-07 8:59 ` Christian Borntraeger
2020-01-07 9:39 ` Michael S. Tsirkin
2020-01-07 11:34 ` Christian Borntraeger [this message]
2020-01-07 11:47 ` Michael S. Tsirkin
2020-01-07 11:55 ` Michael S. Tsirkin
2020-01-07 12:16 ` Christian Borntraeger
2020-01-20 6:27 ` Michael S. Tsirkin
2020-01-22 19:32 ` Christian Borntraeger
2020-02-06 14:22 ` eperezma
2020-02-06 15:12 ` Christian Borntraeger
2020-02-06 22:17 ` Michael S. Tsirkin
2020-02-07 7:47 ` Christian Borntraeger
2020-02-07 7:58 ` Michael S. Tsirkin
2020-02-07 8:13 ` Christian Borntraeger
2020-02-07 8:53 ` Cornelia Huck
2020-02-07 10:07 ` Michael S. Tsirkin
[not found] ` <CAJaqyWfngzP4d01B6+Sqt8FXN6jX7kGegjx8ie4no_1Er3igQA@mail.gmail.com>
2020-02-10 10:09 ` Christian Borntraeger
2020-02-10 11:01 ` Christian Borntraeger
2020-02-11 9:33 ` Eugenio Pérez
2020-02-11 9:56 ` Christian Borntraeger
2020-02-11 10:07 ` Christian Borntraeger
2020-02-11 13:04 ` Eugenio Pérez
2020-02-11 13:13 ` Christian Borntraeger
2020-02-12 16:34 ` Eugenio Pérez
2020-02-13 9:30 ` Christian Borntraeger
2020-02-13 10:47 ` Eugenio Pérez
2020-02-13 13:09 ` Christian Borntraeger
2020-02-13 16:29 ` Eugenio Pérez
2020-02-13 16:32 ` Christian Borntraeger
2020-02-14 7:06 ` Eugenio Pérez
2020-02-14 7:33 ` Christian Borntraeger
2020-02-14 7:40 ` Eugenio Perez Martin
2020-02-14 7:43 ` Christian Borntraeger
2020-02-14 7:47 ` Christian Borntraeger
2020-02-14 12:17 ` Eugenio Pérez
2020-02-14 12:22 ` Christian Borntraeger
2020-02-14 12:26 ` Eugenio Pérez
2020-02-14 12:34 ` Christian Borntraeger
2020-03-27 11:08 ` Eugenio Pérez
2020-03-27 15:46 ` Christian Borntraeger
2020-02-11 13:57 ` Michael S. Tsirkin
2020-03-27 8:03 ` Eugenio Perez Martin
2020-02-06 22:07 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6795e53-d12c-0709-c2e9-e35d9af1f693@de.ibm.com \
--to=borntraeger@de$(echo .)ibm.com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mst@redhat$(echo .)com \
--cc=pasic@linux$(echo .)ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox