From: Randy Dunlap <rdunlap@infradead•org>
To: Florent Revest <revest@chromium•org>, bpf@vger•kernel.org
Cc: ast@kernel•org, daniel@iogearbox•net, andrii@kernel•org,
kpsingh@chromium•org, kafai@fb•com, linux-next@vger•kernel.org,
linux-kernel@vger•kernel.org, kernel test robot <lkp@intel•com>
Subject: Re: [PATCH bpf-next v3] bpf: Only provide bpf_sock_from_file with CONFIG_NET
Date: Tue, 8 Dec 2020 12:06:16 -0800 [thread overview]
Message-ID: <c8dd9a41-3e45-fb32-1074-e23ebe3cb2e5@infradead.org> (raw)
In-Reply-To: <20201208173623.1136863-1-revest@chromium.org>
On 12/8/20 9:36 AM, Florent Revest wrote:
> This moves the bpf_sock_from_file definition into net/core/filter.c
> which only gets compiled with CONFIG_NET and also moves the helper proto
> usage next to other tracing helpers that are conditional on CONFIG_NET.
>
> This avoids
> ld: kernel/trace/bpf_trace.o: in function `bpf_sock_from_file':
> bpf_trace.c:(.text+0xe23): undefined reference to `sock_from_file'
> When compiling a kernel with BPF and without NET.
>
> Reported-by: kernel test robot <lkp@intel•com>
> Reported-by: Randy Dunlap <rdunlap@infradead•org>
> Acked-by: Randy Dunlap <rdunlap@infradead•org>
I would say that I didn't ack this version of the patch (hey,
it's 3x the size of the v1/v2 patches), but I have just
rebuilt with v3, so the Ack is OK. :)
> Signed-off-by: Florent Revest <revest@chromium•org>
> ---
> include/linux/bpf.h | 1 +
> kernel/trace/bpf_trace.c | 22 ++--------------------
> net/core/filter.c | 18 ++++++++++++++++++
> 3 files changed, 21 insertions(+), 20 deletions(-)
--
~Randy
next prev parent reply other threads:[~2020-12-08 20:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 17:36 [PATCH bpf-next v3] bpf: Only provide bpf_sock_from_file with CONFIG_NET Florent Revest
2020-12-08 20:06 ` Randy Dunlap [this message]
2020-12-08 20:19 ` Florent Revest
2020-12-08 20:54 ` Martin KaFai Lau
2020-12-08 21:58 ` KP Singh
2020-12-09 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8dd9a41-3e45-fb32-1074-e23ebe3cb2e5@infradead.org \
--to=rdunlap@infradead$(echo .)org \
--cc=andrii@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=kafai@fb$(echo .)com \
--cc=kpsingh@chromium$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=lkp@intel$(echo .)com \
--cc=revest@chromium$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox