From: Jiri Slaby <jslaby@suse•cz>
To: Stephen Rothwell <sfr@canb•auug.org.au>, Greg KH <greg@kroah•com>
Cc: Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>
Subject: Re: linux-next: manual merge of the tty tree with Linus' tree
Date: Mon, 16 Mar 2020 07:34:11 +0100 [thread overview]
Message-ID: <ccc23257-233e-ca00-9fa6-596bc4b08dae@suse.cz> (raw)
In-Reply-To: <20200310144013.6df85b46@canb.auug.org.au>
[-- Attachment #1.1: Type: text/plain, Size: 1590 bytes --]
On 10. 03. 20, 4:40, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next merge of the tty tree got a conflict in:
>
> drivers/tty/vt/selection.c
>
> between commits:
>
> 4b70dd57a15d ("vt: selection, push console lock down")
> e8c75a30a23c ("vt: selection, push sel_lock up")
>
> from Linus' tree and commits:
>
> 9256d09f1da1 ("vt: selection, create struct from console selection globals")
> bc80932cc25a ("vt: selection, indent switch-case properly")
>
> from the tty tree.
>
> I fixed it up (I think - see below) and can carry the fix as necessary.
> This is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging. You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
I checked the result previously, but now I see a double lock there. Did
something change?
Anyway, vc_sel.lock cannot be taken in both set_selection_kernel and
__set_selection_kernel:
--- a/drivers/tty/vt/selection.c
+++ b/drivers/tty/vt/selection.c
@@ -219,7 +219,6 @@ static int __set_selection_kernel(struct
tiocl_selection *v, struct tty_struct *
if (ps > pe) /* make vc_sel.start <= vc_sel.end */
swap(ps, pe);
- mutex_lock(&vc_sel.lock);
if (vc_sel.cons != vc_cons[fg_console].d) {
clear_selection();
vc_sel.cons = vc_cons[fg_console].d;
thanks,
--
js
suse labs
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-03-16 6:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 3:40 linux-next: manual merge of the tty tree with Linus' tree Stephen Rothwell
2020-03-10 9:04 ` Greg KH
2020-03-10 10:52 ` Jiri Slaby
2020-03-16 6:38 ` Jiri Slaby
2020-03-16 7:46 ` Greg KH
2020-03-16 6:34 ` Jiri Slaby [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-05-20 2:31 Stephen Rothwell
2016-05-21 3:26 ` Greg KH
2014-05-05 5:41 Stephen Rothwell
2014-05-05 21:02 ` Greg KH
2013-01-21 3:46 Stephen Rothwell
2013-01-21 21:02 ` Greg KH
2013-01-25 20:57 ` Greg KH
2013-01-17 2:04 Stephen Rothwell
2013-01-18 0:41 ` Greg KH
2011-10-25 8:18 Stephen Rothwell
2011-10-25 10:03 ` Nicolas Ferre
2011-10-25 8:12 Stephen Rothwell
2011-10-25 12:02 ` Greg KH
2011-02-24 5:34 Stephen Rothwell
2011-02-24 19:39 ` Greg KH
2011-02-25 5:11 ` Stephen Rothwell
2011-02-25 5:48 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccc23257-233e-ca00-9fa6-596bc4b08dae@suse.cz \
--to=jslaby@suse$(echo .)cz \
--cc=greg@kroah$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox