From: Dmitry Osipenko <dmitry.osipenko@collabora•com>
To: Brahmajit Das <listout@listout•xyz>,
airlied@redhat•com, kraxel@redhat•com,
gurchetansingh@chromium•org, olvaffe@gmail•com, simona@ffwll•ch
Cc: linux-next@vger•kernel.org, virtualization@lists•linux.dev,
dri-devel@lists•freedesktop.org
Subject: Re: [PATCH] drm/virtio: use new debugfs device-centered functions
Date: Mon, 11 Aug 2025 13:56:02 +0300 [thread overview]
Message-ID: <d36e24ce-c2cb-4d44-aacd-aa1e44665c75@collabora.com> (raw)
In-Reply-To: <20250809125443.4011734-1-listout@listout.xyz>
On 8/9/25 15:54, Brahmajit Das wrote:
> Replace the use of drm_debugfs_create_files() with the new
> drm_debugfs_add_files() function, which centers the debugfs files
> management on the drm_device instead of drm_minor.
>
> Signed-off-by: Brahmajit Das <listout@listout•xyz>
> ---
> drivers/gpu/drm/virtio/virtgpu_debugfs.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_debugfs.c b/drivers/gpu/drm/virtio/virtgpu_debugfs.c
> index 853dd9aa397e..b7c895fe5ddc 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_debugfs.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_debugfs.c
> @@ -94,7 +94,7 @@ virtio_gpu_debugfs_host_visible_mm(struct seq_file *m, void *data)
> return 0;
> }
>
> -static struct drm_info_list virtio_gpu_debugfs_list[] = {
> +static struct drm_debugfs_info virtio_gpu_debugfs_list[] = {
> { "virtio-gpu-features", virtio_gpu_features },
> { "virtio-gpu-irq-fence", virtio_gpu_debugfs_irq_info, 0, NULL },
> { "virtio-gpu-host-visible-mm", virtio_gpu_debugfs_host_visible_mm },
> @@ -105,7 +105,6 @@ static struct drm_info_list virtio_gpu_debugfs_list[] = {
> void
> virtio_gpu_debugfs_init(struct drm_minor *minor)
> {
> - drm_debugfs_create_files(virtio_gpu_debugfs_list,
> - VIRTIO_GPU_DEBUGFS_ENTRIES,
> - minor->debugfs_root, minor);
> + drm_debugfs_add_files(minor->dev, virtio_gpu_debugfs_list,
> + VIRTIO_GPU_DEBUGFS_ENTRIES);
> }
drm_debugfs_create_files() uses drm_info_node, while
drm_debugfs_add_files() uses drm_debugfs_entry. This patch looks wrong
and, AFAICT, doesn't improve anything. Hence, let's keep this code as-is
if there is no real benefit from the change.
--
Best regards,
Dmitry
prev parent reply other threads:[~2025-08-11 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-09 12:54 [PATCH] drm/virtio: use new debugfs device-centered functions Brahmajit Das
2025-08-11 10:56 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d36e24ce-c2cb-4d44-aacd-aa1e44665c75@collabora.com \
--to=dmitry.osipenko@collabora$(echo .)com \
--cc=airlied@redhat$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=gurchetansingh@chromium$(echo .)org \
--cc=kraxel@redhat$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=listout@listout$(echo .)xyz \
--cc=olvaffe@gmail$(echo .)com \
--cc=simona@ffwll$(echo .)ch \
--cc=virtualization@lists$(echo .)linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox