From: Daniel Lezcano <daniel.lezcano@linaro•org>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Zhang Rui <rui.zhang@intel•com>,
Eduardo Valentin <edubezval@gmail•com>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Andrey Smirnov <andrew.smirnov@gmail•com>
Subject: Re: linux-next: build failure after merge of the thermal tree
Date: Fri, 20 Dec 2019 09:25:19 +0100 [thread overview]
Message-ID: <d59998e8-6b34-d508-f145-f1ef80f50b39@linaro.org> (raw)
In-Reply-To: <20191220110421.2c155cbf@canb.auug.org.au>
[-- Attachment #1.1: Type: text/plain, Size: 2184 bytes --]
On 20/12/2019 01:04, Stephen Rothwell wrote:
> Hi Daniel,
>
> On Fri, 13 Dec 2019 02:03:05 +0100 Daniel Lezcano <daniel.lezcano@linaro•org> wrote:
>>
>> On 12/12/2019 23:14, Stephen Rothwell wrote:
>>>
>>> On Thu, 12 Dec 2019 09:50:20 +1100 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>>>>
>>>> After merging the thermal tree, today's linux-next build (x86_64
>>>> allmodconfig) failed like this:
>>>>
>>>> drivers/thermal/qoriq_thermal.c: In function 'qoriq_tmu_probe':
>>>> drivers/thermal/qoriq_thermal.c:247:20: error: 'SZ_4K' undeclared (first use in this function)
>>>> 247 | .max_register = SZ_4K,
>>>> | ^~~~~
>>>>
>>>> Caused by commit
>>>>
>>>> c98030e5440d ("thermal: qoriq: Convert driver to use regmap API")
>>>>
>>>> I have used the thermal tree from next-20191211 for today.
>>>
>>> Today, I applied the following patch instead:
>>
>> Thanks for the fix, I'll fold it with the commit c98030e5440d in order
>> to recover the bisectability.
>>
>>> From: Stephen Rothwell <sfr@canb•auug.org.au>
>>> Date: Fri, 13 Dec 2019 09:08:24 +1100
>>> Subject: [PATCH] thermal: qoriq: using SZ_4K requires linux/sizes.h
>>>
>>> Fixes: c98030e5440d ("thermal: qoriq: Convert driver to use regmap API")
>>> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
>>> ---
>>> drivers/thermal/qoriq_thermal.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c
>>> index b75d34e07da5..874bc46e6c73 100644
>>> --- a/drivers/thermal/qoriq_thermal.c
>>> +++ b/drivers/thermal/qoriq_thermal.c
>>> @@ -10,6 +10,7 @@
>>> #include <linux/of.h>
>>> #include <linux/of_address.h>
>>> #include <linux/regmap.h>
>>> +#include <linux/sizes.h>
>>> #include <linux/thermal.h>
>>>
>>> #include "thermal_core.h"
>
> I am still applying this patch ...
It should be fixed now.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-12-20 8:25 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 22:50 linux-next: build failure after merge of the thermal tree Stephen Rothwell
2019-12-12 22:14 ` Stephen Rothwell
2019-12-13 1:03 ` Daniel Lezcano
2019-12-20 0:04 ` Stephen Rothwell
2019-12-20 8:25 ` Daniel Lezcano [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-27 12:56 Mark Brown
2026-05-27 19:50 ` Ronald Claveau
2026-05-29 14:57 ` Mark Brown
2023-12-18 23:34 Stephen Rothwell
2023-12-19 2:10 ` Fabio Estevam
2023-12-19 17:59 ` Daniel Lezcano
2023-12-21 1:17 ` Stephen Rothwell
2023-12-21 15:23 ` Fabio Estevam
2023-01-24 23:02 Stephen Rothwell
2023-01-16 0:08 Stephen Rothwell
2023-01-04 23:46 Stephen Rothwell
2023-01-05 9:38 ` Daniel Lezcano
2022-08-03 13:05 broonie
2022-08-03 13:24 ` Daniel Lezcano
2022-08-01 22:35 broonie
2022-08-02 15:04 ` Mark Brown
2022-08-02 15:19 ` Daniel Lezcano
2020-12-15 1:58 Stephen Rothwell
2020-03-23 0:08 Stephen Rothwell
2020-03-23 6:59 ` Zhang Rui
2020-03-03 6:07 Stephen Rothwell
2020-03-03 7:55 ` Daniel Lezcano
2020-03-03 7:57 ` Anson Huang
2018-12-07 1:24 Stephen Rothwell
2018-12-07 6:57 ` Amit Kucheria
2018-06-08 0:51 Stephen Rothwell
2018-06-08 1:07 ` Stephen Rothwell
2014-12-09 2:17 Stephen Rothwell
2014-12-09 2:31 ` Aaron Lu
2014-12-09 2:32 ` Zhang Rui
2014-10-16 1:53 Stephen Rothwell
2014-10-10 1:14 Stephen Rothwell
2014-10-10 8:19 ` Zhang Rui
2012-10-08 0:02 Stephen Rothwell
2012-10-08 2:14 ` Zhang, Rui
2012-10-09 2:11 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d59998e8-6b34-d508-f145-f1ef80f50b39@linaro.org \
--to=daniel.lezcano@linaro$(echo .)org \
--cc=andrew.smirnov@gmail$(echo .)com \
--cc=edubezval@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rui.zhang@intel$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox