From: Arun Easi <aeasi@marvell•com>
To: Bart Van Assche <bvanassche@acm•org>
Cc: Steven Rostedt <rostedt@goodmis•org>,
Martin Petersen <martin.petersen@oracle•com>,
Sudip Mukherjee <sudipm.mukherjee@gmail•com>,
James Bottomley <jejb@linux•ibm.com>,
<linux-scsi@vger•kernel.org>, <linux-kernel@vger•kernel.org>,
<linux-next@vger•kernel.org>,
<GR-QLogic-Storage-Upstream@marvell•com>
Subject: Re: [EXT] Re: [PATCH v2 1/1] tracing: Fix compile error in trace_array calls when TRACING is disabled
Date: Wed, 7 Sep 2022 16:10:55 -0700 [thread overview]
Message-ID: <d607720a-b940-de99-2e78-bd6207d03c5a@marvell.com> (raw)
In-Reply-To: <32dee739-58fb-e371-2808-d40a2ee90ee0@marvell.com>
On Wed, 7 Sep 2022, 3:52pm, Arun Easi wrote:
> On Wed, 7 Sep 2022, 12:27pm, Bart Van Assche wrote:
>
> > External Email
> >
> > ----------------------------------------------------------------------
> > On 9/7/22 11:57, Arun Easi wrote:
> > > +#else /* CONFIG_TRACING */
> > > +static inline int register_ftrace_export(struct trace_export *export)
> > > +{
> > > + return -EINVAL;
> > > +}
> > > +static inline int unregister_ftrace_export(struct trace_export *export)
> > > +{
> > > + return 0;
> > > +}
> >
> > Isn't it recommended to leave a blank line between function definitions?
> >
> > > +static inline int
> > > +trace_array_printk(struct trace_array *tr, unsigned long ip,
> > > + const char *fmt, ...)
> >
> > This is not the recommended way to format a function definition.
>
> That was mostly a Y&P from the prototype earlier in the file. Is it the
> linebreak after "int" you are referring to, or are there more?
>
> > Consider running git clang-format HEAD^.
>
> It is a bit cryptic to me what it is complaining about (sorry
> clang-format newbie here):
>
> # git clang-format -v HEAD^
> Running clang-format on the following files:
> include/linux/trace.h
> YAML:671:20: error: unknown enumerated scalar
> SpaceBeforeParens: ControlStatementsExceptForEachMacros
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Error reading /root/aeasi/src/mkp.git/.clang-format: Invalid argument
> error: `clang-format -lines=29:30 -lines=51:84 include/linux/trace.h` failed
>
> Perhaps my clang-tools are not recent enough.
>
> # clang-format --version
> clang-format version 10.0.1 (Red Hat 10.0.1-1.module+el8.3.0+7459+90c24896)
>
> Still digging..
>
Never mind.
Moved to a different machine with newer git and "clang-format" is working
fine. I will post v3 shortly.
Regards,
-Arun
>
>
> >
> > > +static inline struct trace_array *
> > > +trace_array_get_by_name(const char *name)
> >
> > Same comment here.
> >
> > Thanks,
> >
> > Bart.
> >
>
next prev parent reply other threads:[~2022-09-07 23:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 18:57 [PATCH v2 0/1] Tracing: Compile error with qla2xxx Arun Easi
2022-09-07 18:57 ` [PATCH v2 1/1] tracing: Fix compile error in trace_array calls when TRACING is disabled Arun Easi
2022-09-07 19:27 ` Bart Van Assche
2022-09-07 20:44 ` Steven Rostedt
2022-09-07 22:52 ` [EXT] " Arun Easi
2022-09-07 23:10 ` Arun Easi [this message]
2022-09-07 23:12 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d607720a-b940-de99-2e78-bd6207d03c5a@marvell.com \
--to=aeasi@marvell$(echo .)com \
--cc=GR-QLogic-Storage-Upstream@marvell$(echo .)com \
--cc=bvanassche@acm$(echo .)org \
--cc=jejb@linux$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=martin.petersen@oracle$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=sudipm.mukherjee@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox