From: Hans de Goede <hdegoede@redhat•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
Alexandre Belloni <alexandre.belloni@free-electrons•com>
Cc: Linux-Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the rtc tree
Date: Mon, 10 Apr 2017 09:45:45 +0200 [thread overview]
Message-ID: <e5cb6b88-ea66-c874-272e-183bba1a2d7a@redhat.com> (raw)
In-Reply-To: <20170410160454.3741cce8@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
Hi,
On 10-04-17 08:04, Stephen Rothwell wrote:
> Hi Alexandre,
>
> After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> ERROR: "legacy_pic" [drivers/rtc/rtc-cmos.ko] undefined!
>
> Caused by commit
>
> d3e3a65c6a96 ("rtc: cmos: Do not assume irq 8 for rtc when there are no legacy irqs")
>
> "legacy_pic" is not exported to modules.
>
> I have used the rtc tree from next-20170407 for today.
I already send out a patch to fix this yesterday. I've attached a copy.
Regards,
Hans
[-- Attachment #2: 0001-x86-i8259-export-legacy_pic-symbol.patch --]
[-- Type: text/x-patch, Size: 1382 bytes --]
>From e869aedc4f19c17057d936f408998da230b92d2f Mon Sep 17 00:00:00 2001
From: Hans de Goede <hdegoede@redhat•com>
Date: Sat, 8 Apr 2017 19:47:45 +0200
Subject: [RFC] x86: i8259: export legacy_pic symbol
The classic PC rtc-coms driver has a workaround for broken ACPI device
nodes for it which lack an irq resource. This workaround used to
unconditionally hardcode the irq to 8 in these cases.
This was causing irq conflict problems on systems without a legacy-pic
so a recent patch added an if (nr_legacy_irqs()) guard to the
workaround to avoid this irq conflict.
nr_legacy_irqs() uses the legacy_pic symbol under the hood causing
an undefined symbol error if the rtc-cmos code is build as a module.
This commit exports the legacy_pic symbol to fix this.
Cc: rtc-linux@googlegroups•com
Cc: alexandre.belloni@free-electrons•com
Signed-off-by: Hans de Goede <hdegoede@redhat•com>
---
Changes in v2:
-Use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL
---
arch/x86/kernel/i8259.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/i8259.c b/arch/x86/kernel/i8259.c
index be22f5a..0bcf43d 100644
--- a/arch/x86/kernel/i8259.c
+++ b/arch/x86/kernel/i8259.c
@@ -418,6 +418,7 @@ struct legacy_pic default_legacy_pic = {
};
struct legacy_pic *legacy_pic = &default_legacy_pic;
+EXPORT_SYMBOL_GPL(legacy_pic);
static int __init i8259A_init_ops(void)
{
--
2.9.3
next prev parent reply other threads:[~2017-04-10 7:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 6:04 linux-next: build failure after merge of the rtc tree Stephen Rothwell
2017-04-10 7:45 ` Hans de Goede [this message]
2017-04-11 0:22 ` Stephen Rothwell
2017-04-11 5:55 ` Alexandre Belloni
2017-04-11 7:52 ` Stephen Rothwell
2017-04-14 10:09 ` Alexandre Belloni
2017-04-14 16:33 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2024-11-13 5:23 Stephen Rothwell
2023-10-16 4:15 Stephen Rothwell
2023-10-16 4:34 ` Alexandre Belloni
2023-10-16 7:11 ` Uwe Kleine-König
2021-09-27 3:10 Stephen Rothwell
2021-09-27 7:16 ` Romain Perier
2021-08-10 5:54 Stephen Rothwell
2020-03-16 5:15 Stephen Rothwell
2020-03-16 6:58 ` Ran Bi
2020-03-16 10:31 ` Alexandre Belloni
2019-10-04 4:37 Stephen Rothwell
2019-02-11 5:24 Stephen Rothwell
2019-02-08 5:55 Stephen Rothwell
2017-05-31 4:33 Stephen Rothwell
2017-05-31 5:45 ` Heiner Kallweit
2017-05-31 7:19 ` Alexandre Belloni
2016-11-08 6:41 Stephen Rothwell
2016-11-08 22:21 ` Alexandre Belloni
2015-12-17 5:03 Stephen Rothwell
2015-12-17 11:21 ` Alexandre Belloni
2015-12-18 15:30 ` Sasha Levin
2015-12-18 16:43 ` Alexandre Belloni
2015-12-22 19:27 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5cb6b88-ea66-c874-272e-183bba1a2d7a@redhat.com \
--to=hdegoede@redhat$(echo .)com \
--cc=alexandre.belloni@free-electrons$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox