Subject: Re: [PATCH 1/3] i2c: designware: Initialize adapter name only when not set

From: Ilpo Järvinen <[email-masked]>
Date: Sat, 31 May 2025 08:14:53 +0300 (EEST)

On Fri, 30 May 2025, Pratap Nirujogi wrote:

> Check if the adapter name is already set in the driver prior
> to initializing with generic name in i2c_dw_probe_master().
> 
> Fixes: 90b85567e457 ("platform/x86: Add AMD ISP platform config for OV05C10")
> Reported-by: Randy Dunlap <[email-masked]>
> Link: https://lore.kernel.org/all/[email-masked]
> Signed-off-by: Pratap Nirujogi <[email-masked]>
> ---
>  drivers/i2c/busses/i2c-designware-master.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
> index c5394229b77f..ab03943d6aaf 100644
> --- a/drivers/i2c/busses/i2c-designware-master.c
> +++ b/drivers/i2c/busses/i2c-designware-master.c
> @@ -1042,8 +1042,9 @@ int i2c_dw_probe_master(struct dw_i2c_dev *dev)
>  	if (ret)
>  		return ret;
>  
> -	snprintf(adap->name, sizeof(adap->name),
> -		 "Synopsys DesignWare I2C adapter");
> +	if (!adap->name[0])
> +		snprintf(adap->name, sizeof(adap->name),
> +			 "Synopsys DesignWare I2C adapter");

I'd convert this to scnprintf() here as well and add to the changelog:

While at it, convert to scnprintf() that is preferred over snprintf().

As with the other patch, this too is missing receipients (as indicated 
by the get_maintainers script).

-- 
 i.