From: Arun Easi <aeasi@marvell•com>
To: Steven Rostedt <rostedt@goodmis•org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail•com>,
Nilesh Javali <njavali@marvell•com>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
<GR-QLogic-Storage-Upstream@marvell•com>,
"James E.J. Bottomley" <jejb@linux•ibm.com>,
<linux-scsi@vger•kernel.org>,
linux-kernel <linux-kernel@vger•kernel.org>,
linux-next <linux-next@vger•kernel.org>
Subject: Re: [EXT] build failure of next-20220906 due to 8bfc149ba24c ("scsi: qla2xxx: Enhance driver tracing with separate tunable and more")
Date: Tue, 6 Sep 2022 14:26:31 -0700 [thread overview]
Message-ID: <e9f5eb5e-3830-d19b-dcb0-05f7a36fcb2d@marvell.com> (raw)
In-Reply-To: <20220906170346.52c3f592@gandalf.local.home>
On Tue, 6 Sep 2022, 2:03pm, Steven Rostedt wrote:
> On Tue, 6 Sep 2022 21:57:10 +0100
> Sudip Mukherjee <sudipm.mukherjee@gmail•com> wrote:
>
> > Thanks, that fixed the build for me. The patch did not apply directly
> > on next-20220906, so I had to modify it a little bit.
> >
> > Tested-by: Sudip Mukherjee <sudipm.mukherjee@gmail•com>
>
> Well, the change needs to go into include/linux/trace.h though.
>
Steve, I was thinking both the fixes stay at least for a short
term the one in qla2xxx to avoid tree dependencies.
Since, the qla_def.h change goes as:
+#ifndef CONFIG_TRACING
+#ifndef trace_array_get_by_name
..it should co-exist when the "#define trace_array_get_by_name" gets
merged in include/linux/trace.h. BTW, I will send out the changes to
trace.h today.
Other alternatives/suggestions welcome.
Regards,
-Arun
next prev parent reply other threads:[~2022-09-06 21:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 14:32 build failure of next-20220906 due to 8bfc149ba24c ("scsi: qla2xxx: Enhance driver tracing with separate tunable and more") Sudip Mukherjee (Codethink)
2022-09-06 16:05 ` [EXT] " Arun Easi
2022-09-06 16:21 ` Steven Rostedt
2022-09-06 20:57 ` Sudip Mukherjee
2022-09-06 21:03 ` Steven Rostedt
2022-09-06 21:26 ` Arun Easi [this message]
2022-09-06 21:41 ` Steven Rostedt
2022-09-06 21:50 ` Arun Easi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9f5eb5e-3830-d19b-dcb0-05f7a36fcb2d@marvell.com \
--to=aeasi@marvell$(echo .)com \
--cc=GR-QLogic-Storage-Upstream@marvell$(echo .)com \
--cc=jejb@linux$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=martin.petersen@oracle$(echo .)com \
--cc=njavali@marvell$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=sudipm.mukherjee@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox