Subject: Re: mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o)

From: Christian König <[email-masked]>
Date: Wed, 6 Oct 2021 09:24:03 +0200

Am 06.10.21 um 09:20 schrieb Stephen Rothwell:
> Hi Randy,
>
> On Tue, 5 Oct 2021 22:48:03 -0700 Randy Dunlap <[email-masked]> wrote:
>> on i386:
>>
>> ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg'
>>
>>
>> Full randconfig fle is attached.
> This would be because CONFIG_DRM_MSM is set but CONFIG_COMMON_CLOCK is
> not and has been exposed by commit
>
>    b3ed524f84f5 ("drm/msm: allow compile_test on !ARM")
>
> from the drm-misc tree.

Good point, how about this change:

diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
index 5879f67bc88c..d9879b011fb0 100644
--- a/drivers/gpu/drm/msm/Kconfig
+++ b/drivers/gpu/drm/msm/Kconfig
@@ -5,7 +5,7 @@ config DRM_MSM
         depends on DRM
         depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST
         depends on IOMMU_SUPPORT
-       depends on (OF && COMMON_CLK) || COMPILE_TEST
+       depends on (OF || COMPILE_TEST) && COMMON_CLK
         depends on QCOM_OCMEM || QCOM_OCMEM=n
         depends on QCOM_LLCC || QCOM_LLCC=n
         depends on QCOM_COMMAND_DB || QCOM_COMMAND_DB=n

Regards,
Christian.