From: Grant Likely <grant.likely@secretlab•ca>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Kumar Gala <galak@kernel•crashing.org>,
subrata@linux•vnet.ibm.com, netdev@vger•kernel.org,
Li Yang <leoli@freescale•com>, Nathan Lynch <ntl@pobox•com>,
Sachin P Sant <sachinp@linux•vnet.ibm.com>,
Linux-Next <linux-next@vger•kernel.org>,
Linux-Kernel <linux-kernel@vger•kernel.org>,
Balbir Singh <balbir@linux•vnet.ibm.com>,
Linuxppc-dev <Linuxppc-dev@ozlabs•org>,
Tony Breeds <tony@bakeyournoodle•com>,
michael@ellerman•id.au, Haiying Wang <Haiying.Wang@freescale•com>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o]
Date: Wed, 17 Jun 2009 11:29:54 -0600 [thread overview]
Message-ID: <fa686aa40906171029p4d5b876fm16d0f144b1a19346@mail.gmail.com> (raw)
In-Reply-To: <20090617233452.03ac78d5.sfr@canb.auug.org.au>
On Wed, Jun 17, 2009 at 7:34 AM, Stephen Rothwell<sfr@canb•auug.org.au> wrote:
> On Wed, 17 Jun 2009 23:23:41 +1000 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>>
>> Hi Kumar,
>>
>> On Wed, 17 Jun 2009 08:07:47 -0500 Kumar Gala <galak@kernel•crashing.org> wrote:
>> >
>> >
>> > I'm confused by the proposed fix as we already have *mdio & *ph
>> > defined in this function:
>>
>> Which tree are you looking at? Linus' tree, and linux-next, do not have
>> those local variables ...
>
> Hmmm, commit 0b9da337dca972e7a4144e298ec3adb8f244d4a4 ("net: Rework
> ucc_geth driver to use of_mdio infrastructure") removed the locals along
> with their usages, then commit 047584ce94108012288554a5f84585d792cc7f8f
> ("net/ucc_geth: Add SGMII support for UEC GETH driver") added more uses
> without adding the variables back.
>
> Here is the patch again:
>
> From: Subrata Modak <subrata@linux•vnet.ibm.com>
> Subject: [PATCH] Fix build error in ucc_geth.c
>
> Fix the following build error:
>
> drivers/net/ucc_geth.c: In function bucc_geth_probeb:
> drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in this function)
> drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is reported only once
> drivers/net/ucc_geth.c:3822: error: for each function it appears in.)
> drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in this function)
> make[2]: *** [drivers/net/ucc_geth.o] Error 1
>
> Signed-off-by: Subrata Modak <subrata@linux•vnet.ibm.com>
>
> --- linux-2.6.30-rc8/drivers/net/ucc_geth.c.orig 2009-06-10 11:58:39.000000000 -0500
> +++ linux-2.6.30-rc8/drivers/net/ucc_geth.c 2009-06-10 22:28:13.000000000 -0500
> @@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_g
>
> static int ucc_geth_probe(struct of_device* ofdev, const struct of_device_id *match)
> {
> + struct device_node *mdio;
> + const phandle *ph;
> struct device *device = &ofdev->dev;
> struct device_node *np = ofdev->node;
> struct net_device *dev = NULL;
Ah, this might not be the right fix then. I'll look.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-06-17 17:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 3:37 [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] Subrata Modak
2009-06-15 6:51 ` Subrata Modak
2009-06-17 12:51 ` Subrata Modak
2009-06-17 13:07 ` Kumar Gala
2009-06-17 13:23 ` Stephen Rothwell
2009-06-17 13:34 ` Stephen Rothwell
2009-06-17 13:49 ` Kumar Gala
2009-06-17 17:29 ` Grant Likely [this message]
2009-06-17 20:37 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40906171029p4d5b876fm16d0f144b1a19346@mail.gmail.com \
--to=grant.likely@secretlab$(echo .)ca \
--cc=Haiying.Wang@freescale$(echo .)com \
--cc=Linuxppc-dev@ozlabs$(echo .)org \
--cc=balbir@linux$(echo .)vnet.ibm.com \
--cc=davem@davemloft$(echo .)net \
--cc=galak@kernel$(echo .)crashing.org \
--cc=leoli@freescale$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=michael@ellerman$(echo .)id.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ntl@pobox$(echo .)com \
--cc=sachinp@linux$(echo .)vnet.ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=subrata@linux$(echo .)vnet.ibm.com \
--cc=tony@bakeyournoodle$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox