From: John Crispin <john@phrozen•org>
To: Paul Gortmaker <paul.gortmaker@windriver•com>, netdev@vger•kernel.org
Cc: Felix Fietkau <nbd@openwrt•org>,
Sean Wang <sean.wang@mediatek•com>,
linux-next@vger•kernel.org, linux-mediatek@lists•infradead.org,
Matthias Brugger <matthias.bgg@gmail•com>,
John Crispin <blogic@openwrt•org>
Subject: Re: [PATCH-next] net: ethernet: mediatek: fix implicit irq include causing build fails
Date: Sun, 23 Jul 2017 17:16:40 +0200 [thread overview]
Message-ID: <faa87d84-936f-8f09-0653-933ee6cccabc@phrozen.org> (raw)
In-Reply-To: <20170723145613.14007-1-paul.gortmaker@windriver.com>
Hi Paul
mark sent the same patch a couple of days ago [1]
John
[1] https://patchwork.ozlabs.org/patch/791550/
On 23/07/17 16:56, Paul Gortmaker wrote:
> To fix:
>
> drivers/net/ethernet/mediatek/mtk_eth_soc.c:1685:1: error: unknown type name 'irqreturn_t'
> drivers/net/ethernet/mediatek/mtk_eth_soc.c: In function 'mtk_handle_irq_rx':
> drivers/net/ethernet/mediatek/mtk_eth_soc.c:1694:9: error: 'IRQ_HANDLED' undeclared (first use in this function)
> drivers/net/ethernet/mediatek/mtk_eth_soc.c:1694:9: note: each undeclared identifier is reported only once for each function it appears in
>
> and similar follow-on errors as seen in arm allmodconfig builds.
>
> Cc: Sean Wang <sean.wang@mediatek•com>
> Cc: Felix Fietkau <nbd@openwrt•org>
> Cc: John Crispin <blogic@openwrt•org>
> Cc: Matthias Brugger <matthias.bgg@gmail•com>
> Cc: linux-mediatek@lists•infradead.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>
> ---
>
> [Seen on current linux-next, where similar implicit irq includes
> were recently revealed by some header shuffle somewhere.]
>
> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index 7e95cf547ff1..ea15eb095d83 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -16,6 +16,7 @@
> #include <linux/of_mdio.h>
> #include <linux/of_net.h>
> #include <linux/mfd/syscon.h>
> +#include <linux/interrupt.h>
> #include <linux/regmap.h>
> #include <linux/clk.h>
> #include <linux/pm_runtime.h>
next prev parent reply other threads:[~2017-07-23 15:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-23 14:56 [PATCH-next] net: ethernet: mediatek: fix implicit irq include causing build fails Paul Gortmaker
2017-07-23 15:16 ` John Crispin [this message]
[not found] ` <faa87d84-936f-8f09-0653-933ee6cccabc-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
2017-07-23 15:43 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faa87d84-936f-8f09-0653-933ee6cccabc@phrozen.org \
--to=john@phrozen$(echo .)org \
--cc=blogic@openwrt$(echo .)org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=nbd@openwrt$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=sean.wang@mediatek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox