From: Randy Dunlap <rdunlap@infradead•org>
To: Alex Deucher <alexdeucher@gmail•com>
Cc: "Stephen Rothwell" <sfr@canb•auug.org.au>,
"Linux Next Mailing List" <linux-next@vger•kernel.org>,
"Pan, Xinhui" <Xinhui.Pan@amd•com>,
"Linux Kernel Mailing List" <linux-kernel@vger•kernel.org>,
"dri-devel@lists•freedesktop.org"
<dri-devel@lists•freedesktop.org>,
"amd-gfx list" <amd-gfx@lists•freedesktop.org>,
"Alex Deucher" <alexander.deucher@amd•com>,
"Christian König" <christian.koenig@amd•com>
Subject: Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)
Date: Wed, 15 Jun 2022 12:44:30 -0700 [thread overview]
Message-ID: <fb53cab1-f693-5309-e06a-0fe0fc932c2c@infradead.org> (raw)
In-Reply-To: <CADnq5_N6gfaPfZJAX4+poWFFruxNdFKZqzXZXosj1A55e-O1mA@mail.gmail.com>
On 6/15/22 12:28, Alex Deucher wrote:
> On Wed, Jun 15, 2022 at 3:01 PM Randy Dunlap <rdunlap@infradead•org> wrote:
>>
>>
>>
>> On 6/14/22 23:01, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20220614:
>>>
>>
>> on i386:
>> # CONFIG_DEBUG_FS is not set
>>
>>
>> ../drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function ‘amdgpu_dm_crtc_late_register’:
>> ../drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:6599:2: error: implicit declaration of function ‘crtc_debugfs_init’; did you mean ‘amdgpu_debugfs_init’? [-Werror=implicit-function-declaration]
>> crtc_debugfs_init(crtc);
>> ^~~~~~~~~~~~~~~~~
>> amdgpu_debugfs_init
>>
>>
>> Full randconfig file is attached.
>
> I tried building with your config and I can't repro this. As Harry
> noted, that function and the whole secure display feature depend on
> debugfs. It should never be built without CONFIG_DEBUG_FS. See
> drivers/gpu/drm/amd/display/Kconfig:
Did you try building with today's linux-next tree?
(whatever is in it)
I have seen this build error multiple times so it shouldn't
be so difficult to repro it.
>> config DRM_AMD_SECURE_DISPLAY
>> bool "Enable secure display support"
>> default n
>> depends on DEBUG_FS
>> depends on DRM_AMD_DC_DCN
>> help
>> Choose this option if you want to
>> support secure display
>>
>> This option enables the calculation
>> of crc of specific region via debugfs.
>> Cooperate with specific DMCU FW.
>
> amdgpu_dm_crtc_late_register is guarded by
> CONIG_DRM_AMD_SECURE_DISPLAY. It's not clear to me how we could hit
> this.
--
~Randy
next prev parent reply other threads:[~2022-06-15 19:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 6:01 linux-next: Tree for Jun 15 Stephen Rothwell
2022-06-15 16:28 ` linux-next: Tree for Jun 15 (drivers/dma/apple-admac.c) Randy Dunlap
2022-06-15 17:10 ` Arnd Bergmann
2022-06-15 17:23 ` Martin Povišer
2022-06-15 19:01 ` linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c) Randy Dunlap
2022-06-15 19:28 ` Alex Deucher
2022-06-15 19:44 ` Randy Dunlap [this message]
2022-06-15 20:13 ` Alex Deucher
2022-06-15 20:27 ` Randy Dunlap
2022-06-15 20:24 ` Nathan Chancellor
2022-06-15 20:45 ` Alex Deucher
2022-06-15 20:52 ` Nathan Chancellor
2022-06-15 23:26 ` Stephen Rothwell
2022-06-16 2:34 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb53cab1-f693-5309-e06a-0fe0fc932c2c@infradead.org \
--to=rdunlap@infradead$(echo .)org \
--cc=Xinhui.Pan@amd$(echo .)com \
--cc=alexander.deucher@amd$(echo .)com \
--cc=alexdeucher@gmail$(echo .)com \
--cc=amd-gfx@lists$(echo .)freedesktop.org \
--cc=christian.koenig@amd$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox