From: Trond Myklebust <trondmy@hammerspace•com>
To: "naresh.kamboju@linaro•org" <naresh.kamboju@linaro•org>,
"jstancek@redhat•com" <jstancek@redhat•com>
Cc: "the_hoang0709@yahoo•com" <the_hoang0709@yahoo•com>,
"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>,
"ltp@lists•linux.it" <ltp@lists•linux.it>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"chrubis@suse•cz" <chrubis@suse•cz>,
"alexey.kodanev@oracle•com" <alexey.kodanev@oracle•com>
Subject: Re: Linux-next-20190823: x86_64/i386: prot_hsymlinks.c:325: Failed to run cmd: useradd hsym
Date: Mon, 26 Aug 2019 15:58:06 +0000 [thread overview]
Message-ID: <fcd20866bb836d45b1e384dd68080c671bcde938.camel@hammerspace.com> (raw)
In-Reply-To: <203971593.8175020.1566830285708.JavaMail.zimbra@redhat.com>
On Mon, 2019-08-26 at 10:38 -0400, Jan Stancek wrote:
> ----- Original Message -----
> > Hi Jan and Cyril,
> >
> > On Mon, 26 Aug 2019 at 16:35, Jan Stancek <jstancek@redhat•com>
> > wrote:
> > >
> > >
> > > ----- Original Message -----
> > > > Hi!
> > > > > Do you see this LTP prot_hsymlinks failure on linux next
> > > > > 20190823 on
> > > > > x86_64 and i386 devices?
> > > > >
> > > > > test output log,
> > > > > useradd: failure while writing changes to /etc/passwd
> > > > > useradd: /home/hsym was created, but could not be removed
> > > >
> > > > This looks like an unrelated problem, failure to write to
> > > > /etc/passwd
> > > > probably means that filesystem is full or some problem happend
> > > > and how
> > > > is remounted RO.
> > >
> > > In Naresh' example, root is on NFS:
> > > root=/dev/nfs rw
> > >
> > > nfsroot=10.66.16.123:/var/lib/lava/dispatcher/tmp/886412/extract-
> > > nfsrootfs-tyuevoxm,tcp,hard,intr
> >
> > Right !
> > root is mounted on NFS.
> >
> > > 10.66.16.123:/var/lib/lava/dispatcher/tmp/886412/extract-
> > > nfsrootfs-tyuevoxm
> > > on / type nfs
> > > (rw,relatime,vers=2,rsize=4096,wsize=4096,namlen=255,hard,nolock,
> > > proto=tcp,timeo=600,retrans=2,sec=sys,mountaddr=10.66.16.123,moun
> > > tvers=1,mountproto=tcp,local_lock=all,addr=10.66.16.123)
> > > devtmpfs on /dev type devtmpfs
> > > (rw,relatime,size=3977640k,nr_inodes=994410,mode=755)
> > >
The only thing I can think of that might cause an EIO on NFSv2 would be
this patch
http://git.linux-nfs.org/?p=trondmy/linux-nfs.git;a=commitdiff;h=627d48e597ec5993c4abb3b81dc75e554a07c7c0
assuming that a bind-related error is leaking through.
I'd suggest something like the following to fix it up:
8<---------------------------------------
From 1e9336ac5363914dfcc1f49bf091409edbf36f8d Mon Sep 17 00:00:00 2001
From: Trond Myklebust <trond.myklebust@hammerspace•com>
Date: Mon, 26 Aug 2019 11:44:04 -0400
Subject: [PATCH] fixup! SUNRPC: Don't handle errors if the bind/connect
succeeded
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace•com>
---
net/sunrpc/clnt.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index f13ec73c8299..a07b516e503a 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -1980,9 +1980,11 @@ call_bind_status(struct rpc_task *task)
dprint_status(task);
trace_rpc_bind_status(task);
- if (task->tk_status >= 0 || xprt_bound(xprt)) {
- task->tk_action = call_connect;
- return;
+ if (task->tk_status >= 0)
+ goto out_next;
+ if (xprt_bound(xprt)) {
+ task->tk_status = 0;
+ goto out_next;
}
switch (task->tk_status) {
@@ -2045,6 +2047,9 @@ call_bind_status(struct rpc_task *task)
rpc_call_rpcerror(task, status);
return;
+out_next:
+ task->tk_action = call_connect;
+ return;
retry_timeout:
task->tk_status = 0;
task->tk_action = call_bind;
@@ -2107,8 +2112,10 @@ call_connect_status(struct rpc_task *task)
clnt->cl_stats->netreconn++;
goto out_next;
}
- if (xprt_connected(xprt))
+ if (xprt_connected(xprt)) {
+ task->tk_status = 0;
goto out_next;
+ }
task->tk_status = 0;
switch (status) {
--
2.21.0
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace•com
next prev parent reply other threads:[~2019-08-26 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 9:47 Linux-next-20190823: x86_64/i386: prot_hsymlinks.c:325: Failed to run cmd: useradd hsym Naresh Kamboju
2019-08-26 10:41 ` Cyril Hrubis
2019-08-26 11:05 ` Jan Stancek
2019-08-26 13:50 ` Naresh Kamboju
2019-08-26 14:38 ` Jan Stancek
2019-08-26 15:58 ` Trond Myklebust [this message]
2019-08-26 23:12 ` Jan Stancek
2019-08-27 0:59 ` Trond Myklebust
2019-08-27 10:25 ` Jan Stancek
2019-08-27 12:58 ` Trond Myklebust
2019-08-27 13:20 ` Jan Stancek
2019-08-27 6:34 ` Naresh Kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcd20866bb836d45b1e384dd68080c671bcde938.camel@hammerspace.com \
--to=trondmy@hammerspace$(echo .)com \
--cc=alexey.kodanev@oracle$(echo .)com \
--cc=chrubis@suse$(echo .)cz \
--cc=jstancek@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=ltp@lists$(echo .)linux.it \
--cc=naresh.kamboju@linaro$(echo .)org \
--cc=the_hoang0709@yahoo$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox