Subject: Re: -next Apr 30: OOPS during eHEA driver initialization

From: Grant Likely <[email-masked]>
Date: Fri, 30 Apr 2010 11:43:22 -0600

On Fri, Apr 30, 2010 at 11:35 AM, Grant Likely
<[email-masked]> wrote:
> On Fri, Apr 30, 2010 at 11:27 AM, Sachin Sant <[email-masked]> wrote:
>> Sachin Sant wrote:
>>>
>>> With today's next eHEA drivers fails to initialize.
>>
>> If i revert the following patch eHEA network interface is initialized
>> properly.
>>
>> commit cebfe0b6709abdab997c1a00499d67efa32ee1f0
>> drivercore: Add of_match_table to the common device drivers
>
> That is an easy one to fix.  I'll get it updated today and send you the result.

Let me know if this patch fixes it:

Cheers,
g.

diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c
index ce957a4..693b0e6 100644
--- a/arch/powerpc/kernel/ibmebus.c
+++ b/arch/powerpc/kernel/ibmebus.c
@@ -201,6 +201,9 @@ static int ibmebus_create_devices(const struct
of_device_id *matches)

 int ibmebus_register_driver(struct of_platform_driver *drv)
 {
+	if (!drv->driver.of_match_table)
+		drv->driver.of_match_table = drv->match_table;
+
 	/* If the driver uses devices that ibmebus doesn't know, add them */
 	ibmebus_create_devices(drv->driver.of_match_table);

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.