From: Takashi Iwai <tiwai@suse•de>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Wu Fengguang <wfg@linux•intel.com>
Subject: Re: [PATCH linux-next] snd-hda: fix build errors
Date: Sat, 22 Nov 2008 10:48:14 +0100 [thread overview]
Message-ID: <s5h4p20ccrl.wl%tiwai@suse.de> (raw)
In-Reply-To: <49271D1A.8040509@oracle.com>
At Fri, 21 Nov 2008 12:42:02 -0800,
Randy Dunlap wrote:
>
> Takashi Iwai wrote:
> > At Fri, 21 Nov 2008 12:02:48 -0800,
> > Randy Dunlap wrote:
> >> From: Randy Dunlap <randy.dunlap@oracle•com>
> >>
> >> First error comes from snd_hda_eld_proc_new() not being static
> >> when CONFIG_PROC_FS=n. After that is fixed, the next problem is:
> >> ERROR: "snd_print_pcm_rates" [sound/pci/hda/snd-hda-intel.ko] undefined!
> >>
> >> so I made a static inline version of that one too, for CONFIG_PROC_FS=n.
> >> Please build/test more config variations.
> >>
> >> LD [M] sound/pci/hda/snd-hda-intel.o
> >> sound/pci/hda/hda_eld.o: In function `snd_hda_eld_proc_new':
> >> (.text+0x0): multiple definition of `snd_hda_eld_proc_new'
> >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here
> >> sound/pci/hda/hda_hwdep.o: In function `snd_hda_eld_proc_new':
> >> (.text+0x0): multiple definition of `snd_hda_eld_proc_new'
> >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here
> >> sound/pci/hda/hda_generic.o: In function `snd_hda_eld_proc_new':
> >> (.text+0x1d): multiple definition of `snd_hda_eld_proc_new'
> >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here
> >> sound/pci/hda/patch_realtek.o: In function `snd_hda_eld_proc_new':
> >> (.text+0x3b): multiple definition of `snd_hda_eld_proc_new'
> >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here
> >> sound/pci/hda/patch_cmedia.o: In function `snd_hda_eld_proc_new':
> >> (.text+0x0): multiple definition of `snd_hda_eld_proc_new'
> >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here
> >> sound/pci/hda/patch_analog.o: In function `snd_hda_eld_proc_new':
> >> (.text+0x0): multiple definition of `snd_hda_eld_proc_new'
> >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here
> >> sound/pci/hda/patch_sigmatel.o: In function `snd_hda_eld_proc_new':
> >> (.text+0x3b): multiple definition of `snd_hda_eld_proc_new'
> >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here
> >> sound/pci/hda/patch_atihdmi.o: In function `snd_hda_eld_proc_new':
> >> (.text+0x3b): multiple definition of `snd_hda_eld_proc_new'
> >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here
> >> sound/pci/hda/patch_conexant.o: In function `snd_hda_eld_proc_new':
> >> (.text+0x0): multiple definition of `snd_hda_eld_proc_new'
> >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here
> >> sound/pci/hda/patch_via.o: In function `snd_hda_eld_proc_new':
> >> (.text+0x0): multiple definition of `snd_hda_eld_proc_new'
> >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here
> >> sound/pci/hda/patch_intelhdmi.o: In function `snd_hda_eld_proc_new':
> >> (.text+0x3b): multiple definition of `snd_hda_eld_proc_new'
> >> sound/pci/hda/hda_codec.o:(.text+0x58): first defined here
> >> make[4]: *** [sound/pci/hda/snd-hda-intel.o] Error 1
> >>
> >> Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
> >> cc: Wu Fengguang <wfg@linux•intel.com>
> >> cc: Takashi Iwai <tiwai@suse•de>
> >> ---
> >> sound/pci/hda/hda_local.h | 7 ++++++-
> >> 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > Thanks, but these have been differently fixed on the latest ALSA tree.
> > snd_print_pcm_*() have to be defined no matter what CONFIG_PROC_FS is.
>
> No problem. Just for clarification, is linux-next one day behind
> your latest tree, or is linux-next using a different branch of it,
> or what?
The former, just due to the time zone :)
thanks,
Takashi
next prev parent reply other threads:[~2008-11-22 9:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 7:19 linux-next: Tree for November 21 Stephen Rothwell
2008-11-21 20:02 ` [PATCH linux-next] snd-hda: fix build errors Randy Dunlap
2008-11-21 20:27 ` Takashi Iwai
2008-11-21 20:42 ` Randy Dunlap
2008-11-22 9:48 ` Takashi Iwai [this message]
2008-11-22 1:39 ` Wu Fengguang
2008-11-22 15:07 ` vme_scc.c breakage (was: Re: linux-next: Tree for November 21) Geert Uytterhoeven
2008-11-22 16:47 ` Alan Cox
2008-11-23 2:29 ` Michael Schmitz
2008-11-23 2:59 ` Brad Boyer
2008-11-23 4:40 ` Michael Schmitz
2008-11-23 9:22 ` Brad Boyer
2008-11-24 1:55 ` Michael Schmitz
2008-11-24 6:08 ` Brad Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4p20ccrl.wl%tiwai@suse.de \
--to=tiwai@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=wfg@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox