Subject: Re: linux-next: sound tree build failure

From: Takashi Iwai <[email-masked]>
Date: Mon, 16 Mar 2009 11:41:21 +0100

At Mon, 16 Mar 2009 21:39:32 +1100,
Stephen Rothwell wrote:
> 
> Hi Takashi,
> 
> Today's linux-next build (powerpc allyesconfig) failed like this:
> 
> sound/soc/codecs/twl4030.c:1400: warning: braces around scalar initializer
> sound/soc/codecs/twl4030.c:1400: warning: (near initialization for 'twl4030_dai.ops')
> sound/soc/codecs/twl4030.c:1401: error: field name not in record or union initializer
> sound/soc/codecs/twl4030.c:1401: error: (near initialization for 'twl4030_dai.ops')
> sound/soc/codecs/twl4030.c:1401: warning: initialization from incompatible pointer type
> sound/soc/codecs/twl4030.c:1402: error: field name not in record or union initializer
> sound/soc/codecs/twl4030.c:1402: error: (near initialization for 'twl4030_dai.ops')
> sound/soc/codecs/twl4030.c:1402: warning: excess elements in scalar initializer
> sound/soc/codecs/twl4030.c:1402: warning: (near initialization for 'twl4030_dai.ops')
> sound/soc/codecs/twl4030.c:1403: error: field name not in record or union initializer
> sound/soc/codecs/twl4030.c:1403: error: (near initialization for 'twl4030_dai.ops')
> sound/soc/codecs/twl4030.c:1403: warning: excess elements in scalar initializer
> sound/soc/codecs/twl4030.c:1403: warning: (near initialization for 'twl4030_dai.ops')
> 
> Caused by commit 6335d05548eece40092000aa91b64a50310d69d5 ("ASoC: make
> ops a pointer in 'struct snd_soc_dai'") which missed a conversion (or a
> later merge missed the fixup) ...

Yep, I found a few other issues with that patch, too...

> I have reverted commit 65ec1cd1e2c6228752d2f167b01e6d291014d249 ("ASoC:
> Merge dai_ops factor out") (which merged in the above commit) for today.

Thanks.  Will fix up later.

Takashi