Subject: Re: [PATCH linux-next] hisax: disable build for big-endian arm

From: Takashi Iwai <[email-masked]>
Date: Fri, 22 Nov 2013 10:25:03 +0100

At Fri, 22 Nov 2013 10:19:07 +0100,
Geert Uytterhoeven wrote:
> 
> On Fri, Nov 22, 2013 at 8:29 AM, Takashi Iwai <[email-masked]> wrote:
> >>  config HISAX_TELESPCI
> >>       bool "Teles PCI"
> >> -     depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
> >> +     depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || (ARM && !CPU_LITTLE_ENDIAN)))
> >
> > Isn't it a bit better to exclude CPU_LITTLE_ENDIAN globally?
> >
> >         depends on PCI && CPU_LITTLE_ENDIAN && (BROKEN || !(SPARC || PPC || PARISC || M68K || MIPS || FRV || XTENSA || ARM))
> 
> CPU_LITTLE_ENDIAN is not defined on all little endian platforms,
> only on those that can support both big and little endian.

Ah, a good point.

> But I guess it wouldn't hurt to move CPU_{BIG,LITTLE}_ENDIAN to
> a common Kconfig file.

Yeah, this make life easier.

thanks,

Takashi