From: Takashi Iwai <tiwai@suse•de>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Jaroslav Kysela <perex@perex•cz>
Subject: Re: [PATCH -next] sound: fix patch_realtek printk format
Date: Tue, 30 Mar 2010 20:03:20 +0200 [thread overview]
Message-ID: <s5hljd91yc7.wl%tiwai@suse.de> (raw)
In-Reply-To: <4BB238ED.9040909@oracle.com>
At Tue, 30 Mar 2010 10:46:21 -0700,
Randy Dunlap wrote:
>
> From: Randy Dunlap <randy.dunlap@oracle•com>
>
> Fix printk format warnings in patch_realtek.c:
>
> ound/pci/hda/patch_realtek.c:5120: warning: format '%s' expects type 'char *', but argument 2 has type 'int'
> sound/pci/hda/patch_realtek.c:5120: warning: too few arguments for format
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
> Cc: Jaroslav Kysela <perex@perex•cz>
> Cc: Takashi Iwai <tiwai@suse•de>
Thanks, this was already fixed for tomorrow's merge.
Takashi
> ---
> sound/pci/hda/patch_realtek.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-next-20100330.orig/sound/pci/hda/patch_realtek.c
> +++ linux-next-20100330/sound/pci/hda/patch_realtek.c
> @@ -5117,7 +5117,8 @@ static void fillup_priv_adc_nids(struct
> }
> if (!spec->num_adc_nids) {
> printk(KERN_WARNING "hda_codec: %s: no valid ADC found;"
> - " using fallback 0x%x\n", fallback_adc);
> + " using fallback 0x%x\n",
> + codec->chip_name, fallback_adc);
> spec->private_adc_nids[0] = fallback_adc;
> spec->adc_nids = spec->private_adc_nids;
> if (fallback_adc != fallback_cap) {
>
prev parent reply other threads:[~2010-03-30 18:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 8:18 linux-next: Tree for March 30 Stephen Rothwell
2010-03-30 17:31 ` [PATCH -next] module.h: add stub for is_module_percpu_address Randy Dunlap
2010-03-31 2:34 ` Tejun Heo
2010-03-31 12:59 ` Rusty Russell
2010-03-30 17:32 ` [PATCH -next] gspca: fix build for INPUT=m or INPUT=n Randy Dunlap
2010-03-30 17:46 ` [PATCH -next] sound: fix patch_realtek printk format Randy Dunlap
2010-03-30 18:03 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hljd91yc7.wl%tiwai@suse.de \
--to=tiwai@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=perex@perex$(echo .)cz \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox