From: Takashi Iwai <tiwai@suse•de>
To: Marek Vasut <marek.vasut@gmail•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Russell King <rmk@arm•linux.org.uk>,
linux-next@vger•kernel.org
Subject: Re: linux-next: arm tree build failure
Date: Tue, 19 Aug 2008 13:21:44 +0200 [thread overview]
Message-ID: <s5hljytw8qf.wl%tiwai@suse.de> (raw)
In-Reply-To: <200808191316.21469.marek.vasut@gmail.com>
At Tue, 19 Aug 2008 13:16:21 +0200,
Marek Vasut wrote:
>
> Dne Tuesday 19 of August 2008 07:53:19 Stephen Rothwell napsal(a):
> > Hi Russell,
> >
> > Today's linux-next build (x86_64 allmodconfig) failed like this:
> >
> > drivers/input/touchscreen/ucb1400_ts.c: In function
> > 'ucb1400_ts_detect_irq': drivers/input/touchscreen/ucb1400_ts.c:333: error:
> > 'NO_IRQ' undeclared (first use in this function)
> >
> > I applied the following patch.
> > --
> > Cheers,
> > Stephen Rothwell sfr@canb•auug.org.au
> > http://www.canb.auug.org.au/~sfr/
> >
> > From 3a6383e5556524c941c1421a0e65a0725189ac9e Mon Sep 17 00:00:00 2001
> > From: Stephen Rothwell <sfr@canb•auug.org.au>
> > Date: Tue, 19 Aug 2008 15:49:30 +1000
> > Subject: [PATCH] ucb1400: restore NO_IRQ definition
> >
> > This piece of code was removed by commit
> > 2881353061f896c3894c64e39cf2be35b36aa9fc ("[ARM] 5184/1: Split ucb1400_ts
> > into core and touchscreen").
> >
> > Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> > ---
> > drivers/input/touchscreen/ucb1400_ts.c | 4 ++++
> > 1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/input/touchscreen/ucb1400_ts.c
> > b/drivers/input/touchscreen/ucb1400_ts.c index 006499b..5498662 100644
> > --- a/drivers/input/touchscreen/ucb1400_ts.c
> > +++ b/drivers/input/touchscreen/ucb1400_ts.c
> > @@ -289,6 +289,10 @@ static void ucb1400_ts_close(struct input_dev *idev)
> > ucb1400_reg_write(ucb->ac97, UCB_TS_CR, 0);
> > }
> >
> > +#ifndef NO_IRQ
> > +#define NO_IRQ 0
> > +#endif
> > +
> > /*
> > * Try to probe our interrupt, rather than relying on lots of
> > * hard-coded machine dependencies.
>
> This is my fault indeed, sorry. I tested only on ARM.
I also got a build error with ucb1400 regarding undefined
gpio_get_value() (sorry I lost the exact build log).
The patch below fixes it, but not 100% sure whether it breaks the
build on ARM. Please check it.
thanks,
Takashi
===
[PATCH] ucb1400 - Remove unneeded inclusion
Including asm-generic/gpio.h causes the compile errors no systems
without GPIO_LIB support.
Signed-off-by: Takashi Iwai <tiwai@suse•de>
diff --git a/include/linux/ucb1400.h b/include/linux/ucb1400.h
index 8c10f31..970473b 100644
--- a/include/linux/ucb1400.h
+++ b/include/linux/ucb1400.h
@@ -24,7 +24,6 @@
#define _LINUX__UCB1400_H
#include <sound/ac97_codec.h>
-#include <asm-generic/gpio.h>
#include <linux/mutex.h>
#include <linux/platform_device.h>
next prev parent reply other threads:[~2008-08-19 11:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 5:53 linux-next: arm tree build failure Stephen Rothwell
2008-08-19 11:16 ` Marek Vasut
2008-08-19 11:21 ` Takashi Iwai [this message]
2008-08-19 16:06 ` Russell King
2008-08-19 16:32 ` Takashi Iwai
2008-08-20 0:01 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2008-09-18 18:09 Stephen Rothwell
2008-09-18 18:26 ` Eric Miao
2008-09-18 18:33 ` Eric Miao
2008-09-18 22:04 ` Russell King
2008-09-18 22:28 ` Eric Miao
2009-02-14 4:27 Stephen Rothwell
2009-02-16 9:23 ` Catalin Marinas
2009-04-14 7:48 Stephen Rothwell
2009-04-14 17:09 ` Russell King
2009-09-10 4:59 Stephen Rothwell
2009-09-14 8:20 ` Russell King
2010-01-28 23:38 Stephen Rothwell
2010-01-29 23:45 ` Russell King
2010-01-30 1:27 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hljytw8qf.wl%tiwai@suse.de \
--to=tiwai@suse$(echo .)de \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=marek.vasut@gmail$(echo .)com \
--cc=rmk@arm$(echo .)linux.org.uk \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox