From: Takashi Iwai <tiwai@suse•de>
To: Troy Kisky <troy.kisky@boundarydevices•com>
Cc: broonie@sirena•org.uk, linux-next@vger•kernel.org
Subject: Re: [PATCH 1/1] [ALSA] SOC: Fix setting codec register with debugfs filesystem merge error
Date: Tue, 04 Nov 2008 08:46:06 +0100 [thread overview]
Message-ID: <s5hod0wrl1d.wl%tiwai@suse.de> (raw)
In-Reply-To: <1225740127-30042-1-git-send-email-troy.kisky@boundarydevices.com>
At Mon, 3 Nov 2008 12:22:07 -0700,
Troy Kisky wrote:
>
> Call device_create_file only once in snd_soc_dapm_sys_add function.
>
> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices•com>
Applied now. Thanks.
Takashi
>
> diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
> index 7bf3c40..0fecbb4 100644
> --- a/sound/soc/soc-dapm.c
> +++ b/sound/soc/soc-dapm.c
> @@ -822,14 +822,8 @@ static DEVICE_ATTR(dapm_widget, 0444, dapm_widget_show, NULL);
>
> int snd_soc_dapm_sys_add(struct device *dev)
> {
> - int ret;
> -
> if (!dapm_status)
> return 0;
> -
> - ret = device_create_file(dev, &dev_attr_dapm_widget);
> - if (ret != 0)
> - return ret;
> return device_create_file(dev, &dev_attr_dapm_widget);
> }
>
> --
> 1.5.4.3
>
prev parent reply other threads:[~2008-11-04 7:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 3:41 linux-next: sound tree build failure Stephen Rothwell
2008-10-31 6:39 ` Takashi Iwai
2008-10-31 20:49 ` Troy Kisky
2008-11-01 9:53 ` Takashi Iwai
2008-11-03 19:22 ` [PATCH 1/1] [ALSA] SOC: Fix setting codec register with debugfs filesystem merge error Troy Kisky
2008-11-03 19:58 ` Mark Brown
2008-11-04 7:46 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hod0wrl1d.wl%tiwai@suse.de \
--to=tiwai@suse$(echo .)de \
--cc=broonie@sirena$(echo .)org.uk \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=troy.kisky@boundarydevices$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox