From: Takashi Iwai <tiwai@suse•de>
To: Randy Dunlap <rdunlap@xenotime•net>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
linux-media@vger•kernel.org,
Mauro Carvalho Chehab <mchehab@infradead•org>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Ondrej Zary <linux@rainbow-software•org>
Subject: Re: linux-next: Tree for Aug 5 (media/radio/radio-sf16fmr2)
Date: Sun, 07 Aug 2011 17:37:43 +0200 [thread overview]
Message-ID: <s5hpqkh9qrc.wl%tiwai@suse.de> (raw)
In-Reply-To: <20110806095004.017f6771.rdunlap@xenotime.net>
At Sat, 6 Aug 2011 09:50:04 -0700,
Randy Dunlap wrote:
>
> On Sat, 06 Aug 2011 10:33:39 +0200 Takashi Iwai wrote:
>
> > At Fri, 5 Aug 2011 16:56:11 -0700,
> > Randy Dunlap wrote:
> > >
> > > On Fri, 5 Aug 2011 14:31:03 +1000 Stephen Rothwell wrote:
> > >
> > > > Hi all,
> > > >
> > > > [The kernel.org mirroring is running slowly today]
> > >
> > > Is media/radio/radio-sf16fmr2 an ISA driver or a PCI driver?
> > > ugh. Or is it an I2C driver?
> > >
> > >
> > > linux-next fails with (this is not a new failure):
> > >
> > > ERROR: "snd_tea575x_init" [drivers/media/radio/radio-sf16fmr2.ko] undefined!
> > > ERROR: "snd_tea575x_exit" [drivers/media/radio/radio-sf16fmr2.ko] undefined!
> > >
> > > The Kconfig entry for RADIO_SF16FMR2 is:
> > >
> > > config RADIO_SF16FMR2
> > > tristate "SF16FMR2 Radio"
> > > depends on ISA && VIDEO_V4L2 && SND
> > >
> > > and the Kconfig entry for SND_TEA575X is (not user visible):
> > >
> > > config SND_TEA575X
> > > tristate
> > > depends on SND_FM801_TEA575X_BOOL || SND_ES1968_RADIO || RADIO_SF16FMR2
> > > default SND_FM801 || SND_ES1968 || RADIO_SF16FMR2
> > >
> > > This latter entry is in sound/pci/Kconfig and is under:
> > > if SND_PCI
> > > so it depends on PCI and SND_PCI.
> > >
> > > This build fails when CONFIG_PCI is not enabled.
> >
> > tea575x-tuner is an i2c component (not meaning Linux i2c-subsystem),
> > thus should be independent from the board bus type.
> > Does a patch like below work?
> >
>
> Yes, it does. Thanks.
>
> Reported-by: Randy Dunlap <rdunlap@xenotime•net>
> Acked-by: Randy Dunlap <rdunlap@xenotime•net>
Thanks, now fixed in sound git tree.
Takashi
>
>
> >
> > thanks,
> >
> > Takashi
> >
> > ---
> > diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
> > index 50abf5b..8816804 100644
> > --- a/sound/pci/Kconfig
> > +++ b/sound/pci/Kconfig
> > @@ -1,5 +1,10 @@
> > # ALSA PCI drivers
> >
> > +config SND_TEA575X
> > + tristate
> > + depends on SND_FM801_TEA575X_BOOL || SND_ES1968_RADIO || RADIO_SF16FMR2
> > + default SND_FM801 || SND_ES1968 || RADIO_SF16FMR2
> > +
> > menuconfig SND_PCI
> > bool "PCI sound devices"
> > depends on PCI
> > @@ -563,11 +568,6 @@ config SND_FM801_TEA575X_BOOL
> > FM801 chip with a TEA5757 tuner (MediaForte SF256-PCS, SF256-PCP and
> > SF64-PCR) into the snd-fm801 driver.
> >
> > -config SND_TEA575X
> > - tristate
> > - depends on SND_FM801_TEA575X_BOOL || SND_ES1968_RADIO || RADIO_SF16FMR2
> > - default SND_FM801 || SND_ES1968 || RADIO_SF16FMR2
> > -
> > source "sound/pci/hda/Kconfig"
> >
> > config SND_HDSP
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-next" in
> > the body of a message to majordomo@vger•kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
prev parent reply other threads:[~2011-08-07 15:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 4:31 linux-next: Tree for Aug 5 Stephen Rothwell
2011-08-05 23:56 ` linux-next: Tree for Aug 5 (media/radio/radio-sf16fmr2) Randy Dunlap
2011-08-06 8:33 ` Takashi Iwai
2011-08-06 16:50 ` Randy Dunlap
2011-08-07 15:37 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hpqkh9qrc.wl%tiwai@suse.de \
--to=tiwai@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux@rainbow-software$(echo .)org \
--cc=mchehab@infradead$(echo .)org \
--cc=rdunlap@xenotime$(echo .)net \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox