From: Takashi Iwai <tiwai@suse•de>
To: Hans-Joachim Picht <hans@linux•vnet.ibm.com>
Cc: linux-next@vger•kernel.org
Subject: Re: [PATCH] fix I/O memory related compile caused by wrong Kconfig dependencies
Date: Wed, 21 May 2008 18:21:29 +0200 [thread overview]
Message-ID: <s5hve17vd9y.wl%tiwai@suse.de> (raw)
In-Reply-To: <20080521160523.GA1351@blc4eb509856389.ibm.com>
At Wed, 21 May 2008 18:05:23 +0200,
Hans-Joachim Picht wrote:
>
> On s390 linux-next fails with the following build error:
>
> sound/core/memory.c: In function 'copy_to_user_fromio':
> sound/core/memory.c:47: error: implicit declaration of function 'memcpy_fromio'
> sound/core/memory.c: In function 'copy_from_user_toio':
> sound/core/memory.c:82: error: implicit declaration of function 'memcpy_toio'
>
> The problem was introduced with the following commit
> 6a5751b42420dce9267d7d915eed8f8673d16fdd ("sound: Convert to menuconfig")
> from Takashi's sound-2.6 tree.
>
> Add "depends on HAS_IOMEM" to this menu to make the sound drivers
> disappear for s390 which does not have I/O memory.
>
> Signed-off-by: Hans-Joachim Picht <hans@linux•vnet.ibm.com>
Thanks. I prefer "depends on" in menuconfig SOUND so that we need no
extra if-endif block. I added the patch below to sound-2.6 tree.
Does it work for you?
Takashi
---
commit d61ed2f0cd8b026b1e363ea638c75f9ae8e4c982
Author: Takashi Iwai <tiwai@suse•de>
Date: Wed May 21 18:18:01 2008 +0200
sound: Fix dependency on CONFIG_HAS_IOMEM
Hans-Joachim Picht reported the missing dependency on CONFIG_HAS_IOMEM
that cuases a build error on s390.
Signed-off-by: Takashi Iwai <tiwai@suse•de>
diff --git a/sound/Kconfig b/sound/Kconfig
index b625855..a37bee0 100644
--- a/sound/Kconfig
+++ b/sound/Kconfig
@@ -3,6 +3,7 @@
menuconfig SOUND
tristate "Sound card support"
+ depends on HAS_IOMEM
help
If you have a sound card in your computer, i.e. if it can say more
than an occasional beep, say Y. Be sure to have all the information
next prev parent reply other threads:[~2008-05-21 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 16:05 [PATCH] fix I/O memory related compile caused by wrong Kconfig dependencies Hans-Joachim Picht
2008-05-21 16:21 ` Takashi Iwai [this message]
2008-05-21 21:30 ` Hans-Joachim Picht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hve17vd9y.wl%tiwai@suse.de \
--to=tiwai@suse$(echo .)de \
--cc=hans@linux$(echo .)vnet.ibm.com \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox