From: Takashi Iwai <tiwai@suse•de>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (sound tree related)
Date: Tue, 28 Jun 2011 08:57:17 +0200 [thread overview]
Message-ID: <s5hy60mtpde.wl%tiwai@suse.de> (raw)
In-Reply-To: <20110628165039.7e1fa073.sfr@canb.auug.org.au>
At Tue, 28 Jun 2011 16:50:39 +1000,
Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the final tree, today's linux-next build (i386 defconfig)
> failed like this:
>
> sound/pci/hda/patch_via.c:185:28: error: field 'loopback' has incomplete type
> sound/pci/hda/patch_via.c:187:22: error: array type has incomplete element type
> sound/pci/hda/patch_via.c: In function 'is_aa_path_mute':
> sound/pci/hda/patch_via.c:891:39: error: dereferencing pointer to incomplete type
> sound/pci/hda/patch_via.c:891:51: error: dereferencing pointer to incomplete type
> sound/pci/hda/patch_via.c:892:11: error: dereferencing pointer to incomplete type
> sound/pci/hda/patch_via.c: In function 'add_loopback_list':
> sound/pci/hda/patch_via.c:2004:29: warning: type defaults to 'int' in type name
> sound/pci/hda/patch_via.c:2004:29: warning: type defaults to 'int' in type name
> sound/pci/hda/patch_via.c:2004:29: error: negative width in bit-field '<anonymous>'
> sound/pci/hda/patch_via.c:2007:6: error: dereferencing pointer to incomplete type
> sound/pci/hda/patch_via.c:2008:6: error: dereferencing pointer to incomplete type
> sound/pci/hda/patch_via.c:2009:6: error: dereferencing pointer to incomplete type
>
> Caused by commit ada509ec00e4 ("ALSA: hda - Simplify analog-low-current
> mode check for VIA codecs") which removed the CONFIG_SND_HDA_POWER_SAVE
> protection of the usage, but not the definition in
> sound/pci/hda/hda_local.h.
>
> I have added the below patch for today:
>
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Tue, 28 Jun 2011 16:46:09 +1000
> Subject: [PATCH] ALSA: hda - remove SND_HDA_POWER_SAVE protection of struct
> hda_loopback_check
>
> to fix build problems when it is disabled.
>
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
Oh, sorry for overlook. Now I applied your fix to sound tree.
thanks,
Takashi
> ---
> sound/pci/hda/hda_local.h | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/sound/pci/hda/hda_local.h b/sound/pci/hda/hda_local.h
> index b333bf4..88b277e 100644
> --- a/sound/pci/hda/hda_local.h
> +++ b/sound/pci/hda/hda_local.h
> @@ -565,7 +565,6 @@ int snd_hda_get_bool_hint(struct hda_codec *codec, const char *key)
> * power-management
> */
>
> -#ifdef CONFIG_SND_HDA_POWER_SAVE
> void snd_hda_schedule_power_save(struct hda_codec *codec);
>
> struct hda_amp_list {
> @@ -582,7 +581,6 @@ struct hda_loopback_check {
> int snd_hda_check_amp_list_power(struct hda_codec *codec,
> struct hda_loopback_check *check,
> hda_nid_t nid);
> -#endif /* CONFIG_SND_HDA_POWER_SAVE */
>
> /*
> * AMP control callbacks
> --
> 1.7.5.4
>
> --
> Cheers,
> Stephen Rothwell sfr@canb•auug.org.au
> http://www.canb.auug.org.au/~sfr/
>
next prev parent reply other threads:[~2011-06-28 6:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 6:50 linux-next: build failure after merge of the final tree (sound tree related) Stephen Rothwell
2011-06-28 6:57 ` Takashi Iwai [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-10-28 14:42 Stephen Rothwell
2013-10-28 15:14 ` Takashi Iwai
2012-10-18 3:16 Stephen Rothwell
2012-10-18 6:18 ` Takashi Iwai
2012-08-24 7:20 Stephen Rothwell
2012-08-25 13:42 ` Takashi Iwai
2012-03-14 7:05 Stephen Rothwell
2012-03-14 7:22 ` Takashi Iwai
2011-11-01 9:24 Stephen Rothwell
2011-11-01 9:48 ` Takashi Iwai
2011-06-14 6:03 Stephen Rothwell
2011-06-14 6:19 ` Takashi Iwai
2011-03-16 6:39 Stephen Rothwell
2011-03-16 6:49 ` Takashi Iwai
2011-01-11 2:20 Stephen Rothwell
2011-01-11 6:40 ` Takashi Iwai
2010-09-21 6:40 Stephen Rothwell
2010-09-21 8:02 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hy60mtpde.wl%tiwai@suse.de \
--to=tiwai@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox