From: Takashi Iwai <tiwai@suse•de>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Clemens Ladisch <clemens@ladisch•de>
Subject: Re: linux-next: sound tree build warning
Date: Tue, 11 Aug 2009 08:17:35 +0200 [thread overview]
Message-ID: <s5hzla6an7k.wl%tiwai@suse.de> (raw)
In-Reply-To: <20090811132258.8e899735.sfr@canb.auug.org.au>
At Tue, 11 Aug 2009 13:22:58 +1000,
Stephen Rothwell wrote:
>
> Hi Takashi,
>
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
>
> sound/usb/usbaudio.c: In function 'init_substream_urbs':
> sound/usb/usbaudio.c:1087: warning: comparison of distinct pointer types lacks a cast
>
> Introduced by commit 765e8db078e63fdc076fcf6024c15d3b7b955746 ("sound:
> usb-audio: do not make URBs longer than sync packet interval").
Thanks, fixed now on sound git tree with the patch below.
Takashi
---
diff --git a/sound/usb/usbaudio.c b/sound/usb/usbaudio.c
index fa3f7a1..5149c58 100644
--- a/sound/usb/usbaudio.c
+++ b/sound/usb/usbaudio.c
@@ -1084,7 +1084,7 @@ static int init_substream_urbs(struct snd_usb_substream *subs, unsigned int peri
urb_packs = 1;
urb_packs *= packs_per_ms;
if (subs->syncpipe)
- urb_packs = min(urb_packs, 1 << subs->syncinterval);
+ urb_packs = min(urb_packs, 1U << subs->syncinterval);
/* decide how many packets to be used */
if (is_playback) {
next prev parent reply other threads:[~2009-08-11 12:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-11 3:22 linux-next: sound tree build warning Stephen Rothwell
2009-08-11 6:17 ` Takashi Iwai [this message]
2009-08-11 6:21 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2009-08-12 1:13 Stephen Rothwell
2009-08-12 5:58 ` Takashi Iwai
2009-08-12 13:33 ` Mark Brown
2009-08-10 4:15 Stephen Rothwell
2009-08-10 7:34 ` Takashi Iwai
2009-08-10 18:43 ` Mark Brown
2009-07-15 3:13 Stephen Rothwell
2009-07-15 8:35 ` Mark Brown
2009-07-15 9:09 ` Takashi Iwai
2009-07-15 9:12 ` Mark Brown
2009-07-08 4:18 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hzla6an7k.wl%tiwai@suse.de \
--to=tiwai@suse$(echo .)de \
--cc=clemens@ladisch$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox