public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6•in-berlin.de>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
	linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
	Mauro Carvalho Chehab <mchehab@infradead•org>
Subject: Re: linux-next: Tree for January 14 (multimedia/firesat-rc)
Date: Wed, 14 Jan 2009 23:01:44 +0100 (CET)	[thread overview]
Message-ID: <tkrat.777f93296cb7b932@s5r6.in-berlin.de> (raw)
In-Reply-To: <496E1F84.7040605@oracle.com>

Randy Dunlap wrote:
> drivers/built-in.o: In function `input_report_key':
> firesat-rc.c:(.text+0x776f3): undefined reference to `input_event'
> drivers/built-in.o: In function `firesat_register_rc':
> (.text+0x777af): undefined reference to `input_allocate_device'
> drivers/built-in.o: In function `firesat_register_rc':
> (.text+0x7781c): undefined reference to `input_register_device'
> drivers/built-in.o: In function `firesat_register_rc':
> (.text+0x77834): undefined reference to `input_free_device'
> drivers/built-in.o: In function `firesat_unregister_rc':
> (.text+0x7779d): undefined reference to `input_unregister_device'
> 
> config attached.
...
> # Input device support
> #
> # CONFIG_INPUT is not set

Thanks.  firesat a.k.a. firedtv lives currently in linux1394-2.6.git.


From: Stefan Richter <stefanr@s5r6•in-berlin.de>
Subject: firedtv: add missing dependency on CONFIG_INPUT

Fix build error \
Reported-by: Randy Dunlap <randy.dunlap@oracle•com>

Perhaps we should make the remote control part of firedtv modular so
that the driver can be built without input support.  But it's not very
likely that anybody would have use for such a constellation.

Signed-off-by: Stefan Richter <stefanr@s5r6•in-berlin.de>
---

I need to fold it into "DVB: add firesat driver" before I submit the
driver for mainline merge.

 drivers/media/dvb/firesat/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/media/dvb/firesat/Kconfig
===================================================================
--- linux.orig/drivers/media/dvb/firesat/Kconfig
+++ linux/drivers/media/dvb/firesat/Kconfig
@@ -1,6 +1,6 @@
 config DVB_FIREDTV
 	tristate "FireDTV (FireWire attached DVB receivers)"
-	depends on DVB_CORE && IEEE1394
+	depends on DVB_CORE && IEEE1394 && INPUT
 	help
 	  Support for DVB receivers from Digital Everywhere, known as FireDTV
 	  and FloppyDTV, which are connected via IEEE 1394 (FireWire).


-- 
Stefan Richter
-=====-==--= ---= -===-
http://arcgraph.de/sr/

  parent reply	other threads:[~2009-01-14 22:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-14  5:50 linux-next: Tree for January 14 Stephen Rothwell
2009-01-14 17:23 ` linux-next: Tree for January 14 (multimedia/firesat-rc) Randy Dunlap
2009-01-14 22:01   ` Stefan Richter
2009-01-14 22:01   ` Stefan Richter [this message]
2009-01-14 22:01   ` Stefan Richter
2009-01-14 17:48 ` [BUILD-FAILURE] next-20090114 - powerpc - drivers/leds/leds-gpio.c Kamalesh Babulal
2009-01-14 17:48 ` Kamalesh Babulal
2009-01-14 17:48 ` Kamalesh Babulal
2009-01-14 18:00 ` [BUILD-FAILURE] next-20090114 - drivers/staging/meilhaus Kamalesh Babulal
2009-01-14 18:04   ` Greg KH
2009-01-14 18:11     ` Randy Dunlap
2009-01-14 18:50       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tkrat.777f93296cb7b932@s5r6.in-berlin.de \
    --to=stefanr@s5r6$(echo .)in-berlin.de \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=mchehab@infradead$(echo .)org \
    --cc=randy.dunlap@oracle$(echo .)com \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox