Re: [patch V2 34/46] PCI/MSI: Make arch_.*_msi_irq[s] fallbacks selectable

public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed

From: Vasily Gorbik <gor@linux•ibm.com>
To: Thomas Gleixner <tglx@linutronix•de>, Qian Cai <cai@redhat•com>
Cc: LKML <linux-kernel@vger•kernel.org>,
	Heiko Carstens <hca@linux•ibm.com>,
	Christian Borntraeger <borntraeger@de•ibm.com>,
	linux-s390@vger•kernel.org,
	Stephen Rothwell <sfr@canb•auug.org.au>,
	linux-next@vger•kernel.org, x86@kernel•org,
	Joerg Roedel <joro@8bytes•org>,
	iommu@lists•linux-foundation.org, linux-hyperv@vger•kernel.org,
	Haiyang Zhang <haiyangz@microsoft•com>,
	Jon Derrick <jonathan.derrick@intel•com>,
	Lu Baolu <baolu.lu@linux•intel.com>, Wei Liu <wei.liu@kernel•org>,
	"K. Y. Srinivasan" <kys@microsoft•com>,
	Stephen Hemminger <sthemmin@microsoft•com>,
	Steve Wahl <steve.wahl@hpe•com>,
	Dimitri Sivanich <sivanich@hpe•com>, Russ Anderson <rja@hpe•com>,
	linux-pci@vger•kernel.org, Bjorn Helgaas <bhelgaas@google•com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm•com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>,
	xen-devel@lists•xenproject.org, Juergen Gross <jgross@suse•com>,
	Boris Ostrovsky <boris.ostrovsky@oracle•com>,
	Stefano Stabellini <sstabellini@kernel•org>,
	Marc Zyngier <maz@kernel•org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
	"Rafael J. Wysocki" <rafael@kernel•org>,
	Megha Dey <megha.dey@intel•com>,
	Jason Gunthorpe <jgg@mellanox•com>,
	Dave Jiang <dave.jiang@intel•com>,
	Alex Williamson <alex.williamson@redhat•com>,
	Jacob Pan <jacob.jun.pan@intel•com>,
	Baolu Lu <baolu.lu@intel•com>, Kevin Tian <kevin.tian@intel•com>,
	Dan Williams <dan.j.williams@intel•com>
Subject: Re: [patch V2 34/46] PCI/MSI: Make arch_.*_msi_irq[s] fallbacks selectable
Date: Sat, 26 Sep 2020 14:38:53 +0200	[thread overview]
Message-ID: <your-ad-here.call-01601123933-ext-6476@work.hours> (raw)
In-Reply-To: <cdfd63305caa57785b0925dd24c0711ea02c8527.camel@redhat.com>

On Fri, Sep 25, 2020 at 09:54:52AM -0400, Qian Cai wrote:
> On Wed, 2020-08-26 at 13:17 +0200, Thomas Gleixner wrote:
> > From: Thomas Gleixner <tglx@linutronix•de>
> > 
> > The arch_.*_msi_irq[s] fallbacks are compiled in whether an architecture
> > requires them or not. Architectures which are fully utilizing hierarchical
> > irq domains should never call into that code.
> > 
> > It's not only architectures which depend on that by implementing one or
> > more of the weak functions, there is also a bunch of drivers which relies
> > on the weak functions which invoke msi_controller::setup_irq[s] and
> > msi_controller::teardown_irq.
> > 
> > Make the architectures and drivers which rely on them select them in Kconfig
> > and if not selected replace them by stub functions which emit a warning and
> > fail the PCI/MSI interrupt allocation.
> > 
> > Signed-off-by: Thomas Gleixner <tglx@linutronix•de>
> 
> Today's linux-next will have some warnings on s390x:
> 
> .config: https://gitlab.com/cailca/linux-mm/-/blob/master/s390.config
> 
> WARNING: unmet direct dependencies detected for PCI_MSI_ARCH_FALLBACKS
>   Depends on [n]: PCI [=n]
>   Selected by [y]:
>   - S390 [=y]
> 
> WARNING: unmet direct dependencies detected for PCI_MSI_ARCH_FALLBACKS
>   Depends on [n]: PCI [=n]
>   Selected by [y]:
>   - S390 [=y]
>

Yes, as well as on mips and sparc which also don't FORCE_PCI.
This seems to work for s390:

diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
index b0b7acf07eb8..41136fbe909b 100644
--- a/arch/s390/Kconfig
+++ b/arch/s390/Kconfig
@@ -192,3 +192,3 @@ config S390
        select PCI_MSI                  if PCI
-       select PCI_MSI_ARCH_FALLBACKS
+       select PCI_MSI_ARCH_FALLBACKS   if PCI
        select SET_FS

next prev parent reply	other threads:[~2020-09-26 12:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200826111628.794979401@linutronix.de>
     [not found] ` <20200826112333.992429909@linutronix.de>
2020-09-25 13:54   ` [patch V2 34/46] PCI/MSI: Make arch_.*_msi_irq[s] fallbacks selectable Qian Cai
2020-09-26 12:38     ` Vasily Gorbik [this message]
2020-09-28 10:11       ` Thomas Gleixner
2020-09-25 15:29 ` [patch V2 00/46] x86, PCI, XEN, genirq ...: Prepare for device MSI Qian Cai
2020-09-25 15:49   ` Peter Zijlstra
2020-09-25 23:14     ` Thomas Gleixner
2020-09-27  8:46       ` [PATCH] x86/apic/msi: Unbreak DMAR and HPET MSI Thomas Gleixner

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:b0b7acf07eb dfblob:41136fbe909 )
 OR (
bs:"Re: [patch V2 34/46] PCI/MSI: Make arch_.*_msi_irq[s] fallbacks selectable" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=your-ad-here.call-01601123933-ext-6476@work.hours \
    --to=gor@linux$(echo .)ibm.com \
    --cc=alex.williamson@redhat$(echo .)com \
    --cc=baolu.lu@intel$(echo .)com \
    --cc=baolu.lu@linux$(echo .)intel.com \
    --cc=bhelgaas@google$(echo .)com \
    --cc=boris.ostrovsky@oracle$(echo .)com \
    --cc=borntraeger@de$(echo .)ibm.com \
    --cc=cai@redhat$(echo .)com \
    --cc=dan.j.williams@intel$(echo .)com \
    --cc=dave.jiang@intel$(echo .)com \
    --cc=gregkh@linuxfoundation$(echo .)org \
    --cc=haiyangz@microsoft$(echo .)com \
    --cc=hca@linux$(echo .)ibm.com \
    --cc=iommu@lists$(echo .)linux-foundation.org \
    --cc=jacob.jun.pan@intel$(echo .)com \
    --cc=jgg@mellanox$(echo .)com \
    --cc=jgross@suse$(echo .)com \
    --cc=jonathan.derrick@intel$(echo .)com \
    --cc=joro@8bytes$(echo .)org \
    --cc=kevin.tian@intel$(echo .)com \
    --cc=konrad.wilk@oracle$(echo .)com \
    --cc=kys@microsoft$(echo .)com \
    --cc=linux-hyperv@vger$(echo .)kernel.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=linux-pci@vger$(echo .)kernel.org \
    --cc=linux-s390@vger$(echo .)kernel.org \
    --cc=lorenzo.pieralisi@arm$(echo .)com \
    --cc=maz@kernel$(echo .)org \
    --cc=megha.dey@intel$(echo .)com \
    --cc=rafael@kernel$(echo .)org \
    --cc=rja@hpe$(echo .)com \
    --cc=sfr@canb$(echo .)auug.org.au \
    --cc=sivanich@hpe$(echo .)com \
    --cc=sstabellini@kernel$(echo .)org \
    --cc=steve.wahl@hpe$(echo .)com \
    --cc=sthemmin@microsoft$(echo .)com \
    --cc=tglx@linutronix$(echo .)de \
    --cc=wei.liu@kernel$(echo .)org \
    --cc=x86@kernel$(echo .)org \
    --cc=xen-devel@lists$(echo .)xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox