Subject: Re: [PATCH] Fix I8042 IRQs on MPC8641 HPCN

From: Segher Boessenkool <[email-masked]>
Date: Wed, 20 Jun 2007 18:07:36 +0200

>>> 	 * IRQ 9:  Level
>>> 	 * IRQ 10: Level
>>> 	 * IRQ 11: Level
>>> -	 * IRQ 12: Level
>>> +	 * IRQ 12: Edge
>>> 	 * IRQ 14: Edge
>>> 	 * IRQ 15: Edge
>>> 	 */
>>> -	outb(0xfa, 0x4d0);
>>> -	outb(0x1e, 0x4d1);
>>> +	outb(0xf8, 0x4d0);
>>> +	outb(0x0e, 0x4d1);
>> The comment doesn't mention IRQ13.  You're changing IRQ9
>> to edge as well; is this an accident?
>
>    Whare -- I'm only seeing bit 1 changing which corresponds to IRQ1 
> and is reserved (0) anyway.

Uh yeah, bit 1, it's hard to count these single-byte quantities :-)

>>  If not, you need to change the comment too.

Segher