From: "Kuppuswamy, Sathyanarayanan" <sathyanarayanan.kuppuswamy@linux•intel.com>
To: Jon Derrick <jonathan.derrick@intel•com>,
Bjorn Helgaas <helgaas@kernel•org>
Cc: Rajat Jain <rajatja@google•com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel•com>,
Frederick Lawler <fred@fredlawl•com>,
Sam Bobroff <sbobroff@linux•ibm.com>,
linux-pci@vger•kernel.org, Olof Johansson <olof@lixom•net>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org,
Bjorn Helgaas <bhelgaas@google•com>,
Alex Williamson <alex.williamson@redhat•com>,
"Patel, Mayurkumar" <mayurkumar.patel@intel•com>,
Oliver O'Halloran <oohall@gmail•com>,
Keith Busch <kbusch@kernel•org>,
Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
Mika Westerberg <mika.westerberg@linux•intel.com>
Subject: Re: [PATCH v2 2/2] PCI/DPC: Allow Native DPC Host Bridges to use DPC
Date: Wed, 22 Apr 2020 15:50:17 -0700 [thread overview]
Message-ID: <0058b993-0663-7fed-ed31-cb0adf845a39@linux.intel.com> (raw)
In-Reply-To: <1587418630-13562-3-git-send-email-jonathan.derrick@intel.com>
On 4/20/20 2:37 PM, Jon Derrick wrote:
> The existing portdrv model prevents DPC services without either OS
> control (_OSC) granted to AER services, a Host Bridge requesting Native
> AER, or using one of the 'pcie_ports=' parameters of 'native' or
> 'dpc-native'.
>
> The DPC port service driver itself will also fail to probe if the kernel
> assumes the port is using Firmware-First AER. It's a reasonable
> expectation that a port using Firmware-First AER will also be using
> Firmware-First DPC, however if a Host Bridge requests Native DPC, the
> DPC driver should allow it and not fail to bind due to AER capability
> settings.
>
> Host Bridges which request Native DPC port services will also likely
> request Native AER, however it shouldn't be a requirement. This patch
> allows ports on those Host Bridges to have DPC port services.
>
> This will avoid the unlikely situation where the port is Firmware-First
> AER and Native DPC, and a BIOS or switch firmware preconfiguration of
> the DPC trigger could result in unhandled DPC events.
>
> Signed-off-by: Jon Derrick <jonathan.derrick@intel•com>
> ---
> drivers/pci/pcie/dpc.c | 3 ++-
> drivers/pci/pcie/portdrv_core.c | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c
> index 7621704..3f3106f 100644
> --- a/drivers/pci/pcie/dpc.c
> +++ b/drivers/pci/pcie/dpc.c
> @@ -284,7 +284,8 @@ static int dpc_probe(struct pcie_device *dev)
> int status;
> u16 ctl, cap;
>
> - if (pcie_aer_get_firmware_first(pdev) && !pcie_ports_dpc_native)
> + if (pcie_aer_get_firmware_first(pdev) && !pcie_ports_dpc_native &&
> + !pci_find_host_bridge(pdev->bus)->native_dpc)
Why do it in probe as well ? if host->native_dpc is not set then the
device DPC probe it self won't happen right ?
> return -ENOTSUPP;
>
> status = devm_request_threaded_irq(device, dev->irq, dpc_irq,
> diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c
> index 50a9522..f2139a1 100644
> --- a/drivers/pci/pcie/portdrv_core.c
> +++ b/drivers/pci/pcie/portdrv_core.c
> @@ -256,7 +256,8 @@ static int get_port_device_capability(struct pci_dev *dev)
> */
> if (pci_find_ext_capability(dev, PCI_EXT_CAP_ID_DPC) &&
> pci_aer_available() &&
> - (pcie_ports_dpc_native || (services & PCIE_PORT_SERVICE_AER)))
> + (pcie_ports_dpc_native || host->native_dpc ||
> + (services & PCIE_PORT_SERVICE_AER)))
> services |= PCIE_PORT_SERVICE_DPC;
>
> if (pci_pcie_type(dev) == PCI_EXP_TYPE_DOWNSTREAM ||
>
next prev parent reply other threads:[~2020-04-22 22:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 21:37 [PATCH v2 0/2] Honoring Native AER/DPC Host Bridges Jon Derrick
2020-04-20 21:37 ` [PATCH v2 1/2] PCI/AER: Allow Native AER Host Bridges to use AER Jon Derrick
2020-04-22 22:48 ` Kuppuswamy, Sathyanarayanan
2020-04-23 15:11 ` Derrick, Jonathan
2020-04-24 23:30 ` Bjorn Helgaas
2020-04-27 16:11 ` Derrick, Jonathan
2020-04-27 22:14 ` Bjorn Helgaas
2020-04-20 21:37 ` [PATCH v2 2/2] PCI/DPC: Allow Native DPC Host Bridges to use DPC Jon Derrick
2020-04-22 22:50 ` Kuppuswamy, Sathyanarayanan [this message]
2020-04-23 15:11 ` Derrick, Jonathan
2020-04-25 20:46 ` Kuppuswamy, Sathyanarayanan
2020-04-27 15:15 ` Derrick, Jonathan
2020-04-27 15:43 ` Kuppuswamy, Sathyanarayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0058b993-0663-7fed-ed31-cb0adf845a39@linux.intel.com \
--to=sathyanarayanan.kuppuswamy@linux$(echo .)intel.com \
--cc=alex.williamson@redhat$(echo .)com \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=bhelgaas@google$(echo .)com \
--cc=fred@fredlawl$(echo .)com \
--cc=helgaas@kernel$(echo .)org \
--cc=jonathan.derrick@intel$(echo .)com \
--cc=kbusch@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mayurkumar.patel@intel$(echo .)com \
--cc=mika.westerberg@linux$(echo .)intel.com \
--cc=olof@lixom$(echo .)net \
--cc=oohall@gmail$(echo .)com \
--cc=rafael.j.wysocki@intel$(echo .)com \
--cc=rajatja@google$(echo .)com \
--cc=sbobroff@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox